Re: [PATCH 00/11] add recipients to search output

diff --git a/a8/092386b03fb1a1fea9887df9f8ce2e0580f633 b/a8/092386b03fb1a1fea9887df9f8ce2e0580f633
new file mode 100644 (file)
index 0000000..ccce23d
--- /dev/null
+++ b/a8/092386b03fb1a1fea9887df9f8ce2e0580f633
@@ -0,0 +1,105 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E0B1D431FBD\r
+       for <notmuch@notmuchmail.org>; Thu, 23 Aug 2012 00:21:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id qNMOzN+2L3Ih for <notmuch@notmuchmail.org>;\r
+       Thu, 23 Aug 2012 00:21:24 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 63BFA431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 23 Aug 2012 00:21:24 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 78BB0100386; Thu, 23 Aug 2012 10:21:33 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 00/11] add recipients to search output\r
+In-Reply-To: <1345427570-26518-1-git-send-email-jrollins@finestructure.net>\r
+References: <1345427570-26518-1-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.14+8~gd6b499d (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 23 Aug 2012 10:21:33 +0300\r
+Message-ID: <m2boi2cbuq.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 23 Aug 2012 07:21:25 -0000\r
+\r
+On Mon, Aug 20 2012, Jameson Graef Rollins wrote:\r
+\r
+> This series is an attempt to add thread recipients to the search\r
+> output.\r
+>\r
+> My personal overall goal of this series is to support the handling of\r
+> drafts in the emacs ui.  For drafts we want to see recipients, instead\r
+> of authors, in the search output.  I can imagine other uses for this\r
+> series as well, though.\r
+>\r
+> The first four patches generalize the author list handling in thread\r
+> objects to handle any address list.  These patches could be applied\r
+> regardless of if the rest of the series is accepted.\r
+>\r
+> After that we modify the thread constructor such that it can hold\r
+> thread recipients as well.  Since there is overhead in retrieving\r
+> thread recipients from the message files (recipients are not stored in\r
+> the database) this is handled with a switch.\r
+>\r
+> Further patches add the new switch to the search CLI that adds thread\r
+> recipients to the structured output formats.  I didn't modify the text\r
+> output format, since there is no way to extend it.  I can imagine\r
+> tweaking the text output such that the author field is instead\r
+> replaced by the recipients (as is done for the emacs UI at the end of\r
+> the series), but that's not done here.\r
+>\r
+> In the emacs UI, I add a new toggle function that will toggle display\r
+> of thread authors or recipients in the 'authors' field of the search\r
+> output.  It's unfortunate that this ambiguity in that field name\r
+> remains, but I didn't know how to change that cleanly.  I'm working on\r
+> some tests for the new emacs functionality that I'll include in the\r
+> inevitable v2 of this series.\r
+\r
+I did not read much of this introduction before browsing to the code, I\r
+was about to comment whether attempt yo do less trivial tests are\r
+to be done.\r
+\r
+> The last patch is mostly just a tickle to suggest adding the\r
+> recipients to the database.  It would make the --include-recipient\r
+> searches much faster of course, but it might be overhead in the\r
+> database that folks aren't interested in.\r
+\r
+I got tickled... adding To (and Cc?!) to the database would also give\r
+(future notmuch?) address completion more addresses to match for.\r
+\r
+We should discuss whether to add other headers too? IIRC someone (Austin?)\r
+mentioned that everything (except Received:) headers could be there ?\r
+\r
+> As always, feedback, review, and comments are much appreciated.\r
+\r
+Overall, the code looks good (to me).\r
+\r
+> jamie.\r
+\r
+Tomi\r