Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by default with --client

diff --git a/84/2bd1ce73d26c00af18570155b123fc706bf980 b/84/2bd1ce73d26c00af18570155b123fc706bf980
new file mode 100644 (file)
index 0000000..a231180
--- /dev/null
+++ b/84/2bd1ce73d26c00af18570155b123fc706bf980
@@ -0,0 +1,95 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 3701E6DE0350\r
+ for <notmuch@notmuchmail.org>; Tue, 29 Sep 2015 12:18:55 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.151\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.151 tagged_above=-999 required=5 tests=[AWL=-0.245,\r
+  SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 3zxPTQFUb_0P for <notmuch@notmuchmail.org>;\r
+ Tue, 29 Sep 2015 12:18:53 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id EAAA46DE025E\r
+ for <notmuch@notmuchmail.org>; Tue, 29 Sep 2015 12:18:52 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 1E55C100080;\r
+ Tue, 29 Sep 2015 22:18:57 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by\r
+ default with --client\r
+In-Reply-To: <87wpva3j37.fsf@zancas.localnet>\r
+References: <cover.1439629384.git.jani@nikula.org>\r
+ <455026447d3f75b1038ac11cebe734431604be9d.1439629384.git.jani@nikula.org>\r
+ <m21tepvpm5.fsf@guru.guru-group.fi> <87wpva3j37.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 29 Sep 2015 22:18:56 +0300\r
+Message-ID: <m2si5xm3tr.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 29 Sep 2015 19:18:55 -0000\r
+\r
+On Mon, Sep 28 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>\r
+>> if [ -n "$AUTO_DAEMON" -a -z "$CREATE_FRAME" ]; then\r
+>>     echo "$0: --auto-daemon is only applicable with --create-frame." >&2\r
+>>     exit 1       \r
+>> fi\r
+>>\r
+>> without this one may execute ./notmuch-emacs-mua --client --auto-daemon\r
+>> which yields starting emacs in daemon mode (in this example it is expected\r
+>> emacs is not running; otherwise --auto-daemon has no use in this example)\r
+>> -- but no ui to that newly-running emacs is provided. Similar behaviour\r
+>> can be observed by the following\r
+>>\r
+>\r
+> I think what you propose is fine for a followup patch; note that the\r
+> scenario you worry about also needs --client to be a problem. Apparently\r
+> nothing is uncontroversial here, but if auto-daemon only works with\r
+> create frame, then perhaps the followup would be to have auto-daemon\r
+> imply create-frame\r
+\r
+Without --client --auto-daemon is no-op (as it is no-op in case emacs\r
+server is already running). I am (only) concerned about user experience\r
+when one runs --client --auto-daemon and user gets nothing (i.e. emacs\r
+server is running in the background w/o any clients connected to it.\r
+\r
+We could make --auto-daemon imply --create-frame, but then \r
+\r
+./notmuch-emacs-mua --auto-daemon (i.e. w/o --client) starts new mail\r
+compose window to separate frame (even though user did not request\r
+it w/ --create-frame)\r
+\r
+(actually I already did the 'imply' option (easy, one line in script,\r
+another in namual), just that testing it gave this thought...\r
+\r
+... therefore I'd rather make ./notmuch-emacs-mua --auto-daemon\r
+spit an error and exit -- but I can be convinced otherwise :)\r
+\r
+Tomi\r