sys-libs/glibc: disable stack protection by default on mips* targets
authorSergei Trofimovich <slyfox@gentoo.org>
Tue, 5 Dec 2017 22:19:47 +0000 (22:19 +0000)
committerSergei Trofimovich <slyfox@gentoo.org>
Wed, 6 Dec 2017 22:15:25 +0000 (22:15 +0000)
Otherwise dlopen() crashes (found on 'top' from 'procps' package).

Original backtrace from qemu-mipsn32 (fails the same way on native host):

```
Program received signal SIGSEGV, Segmentation fault.
0x408cb908 in _dlerror_run (operate=operate@entry=0x408cadf0 <dlopen_doit>, args=args@entry=0x407feb28) at dlerror.c:163
163       result->errcode = _dl_catch_error (&result->objname, &result->errstring,
(gdb) bt
 #0  0x408cb908 in _dlerror_run (operate=operate@entry=0x408cadf0 <dlopen_doit>, args=args@entry=0x407feb28) at dlerror.c:163
 #1  0x408caf4c in __dlopen (file=file@entry=0x10012d58 "libnuma.so", mode=mode@entry=1) at dlopen.c:87
 #2  0x1000306c in before (me=0x407ff382 "/usr/mips64-unknown-linux-gnu/usr/bin/top") at top/top.c:3308
 #3  0x10001a10 in main (dont_care_argc=<optimized out>, argv=0x407ff1a4) at top/top.c:5721
```

Reported-by: Matt Turner
Bug: https://bugs.gentoo.org/640130
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
eclass/toolchain-glibc.eclass
sys-libs/glibc/glibc-2.26-r3.ebuild
sys-libs/glibc/glibc-9999.ebuild

index e9cf01cf8c279b3e49b20bb66567b4abe01c7239..6580be2fb1e047935c2abe9a5ec00ad1523d879b 100644 (file)
@@ -796,6 +796,11 @@ glibc_do_configure() {
 
        if version_is_at_least 2.25 ; then
                case ${CTARGET} in
+                       mips*)
+                               # dlopen() detects stack smash on mips n32 ABI.
+                               # Cause is unknown: https://bugs.gentoo.org/640130
+                               myconf+=( --enable-stack-protector=no )
+                               ;;
                        powerpc-*)
                                # Currently gcc on powerpc32 generates invalid code for
                                # __builtin_return_address(0) calls. Normally programs
index c2f0607994038c967fbfef31476b0851c7e4586d..0edb97902c8525ff0814ee6d0dd66b410e772615 100644 (file)
@@ -316,6 +316,11 @@ glibc_do_configure() {
        popd > /dev/null
 
        case ${CTARGET} in
+               mips*)
+                       # dlopen() detects stack smash on mips n32 ABI.
+                       # Cause is unknown: https://bugs.gentoo.org/640130
+                       myconf+=( --enable-stack-protector=no )
+                       ;;
                powerpc-*)
                        # Currently gcc on powerpc32 generates invalid code for
                        # __builtin_return_address(0) calls. Normally programs
index 60b17cfe67bcd5b812976bb809bdbcc016725eda..e29a0778fd5dcd0b25a02cb54c4b654412ee253d 100644 (file)
@@ -316,6 +316,11 @@ glibc_do_configure() {
        local myconf=()
 
        case ${CTARGET} in
+               mips*)
+                       # dlopen() detects stack smash on mips n32 ABI.
+                       # Cause is unknown: https://bugs.gentoo.org/640130
+                       myconf+=( --enable-stack-protector=no )
+                       ;;
                powerpc-*)
                        # Currently gcc on powerpc32 generates invalid code for
                        # __builtin_return_address(0) calls. Normally programs