Re: Re: [PATCH 0/3] Introduce the add command

diff --git a/9f/50b89462f39ce69a5bacfcda310f4c18bccbe5 b/9f/50b89462f39ce69a5bacfcda310f4c18bccbe5
new file mode 100644 (file)
index 0000000..4cfc096
--- /dev/null
+++ b/9f/50b89462f39ce69a5bacfcda310f4c18bccbe5
@@ -0,0 +1,104 @@
+Return-Path: <Vladimir.Marek@Oracle.COM>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 13E18431FBD\r
+       for <notmuch@notmuchmail.org>; Sun, 21 Jul 2013 14:47:52 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.299\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.299 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id JZC1QeKYpWIq for <notmuch@notmuchmail.org>;\r
+       Sun, 21 Jul 2013 14:47:44 -0700 (PDT)\r
+Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id F246E431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 21 Jul 2013 14:47:43 -0700 (PDT)\r
+Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93])\r
+       by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with\r
+       ESMTP id r6LLldmq018940\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\r
+       Sun, 21 Jul 2013 21:47:39 GMT\r
+Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85])\r
+       by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id\r
+       r6LLlcdF007796\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\r
+       Sun, 21 Jul 2013 21:47:38 GMT\r
+Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54])\r
+       by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id\r
+       r6LLlbmO007792; Sun, 21 Jul 2013 21:47:38 GMT\r
+Received: from virt.cz.oracle.com (/10.163.102.127)\r
+       by default (Oracle Beehive Gateway v4.0)\r
+       with ESMTP ; Sun, 21 Jul 2013 14:47:37 -0700\r
+Date: Sun, 21 Jul 2013 23:47:35 +0200\r
+From: Vladimir Marek <Vladimir.Marek@Oracle.COM>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: Re: [PATCH 0/3] Introduce the add command\r
+Message-ID: <20130721214735.GC4405@virt.cz.oracle.com>\r
+References: <1373762746-22308-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <87wqom8v2x.fsf@servo.finestructure.net>\r
+       <87r4es8h0p.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+In-Reply-To: <87r4es8h0p.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/ (2012-12-30)\r
+X-Source-IP: ucsinet21.oracle.com [156.151.31.93]\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 21 Jul 2013 21:47:52 -0000\r
+\r
+> > On Sat, Jul 13 2013, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:\r
+> >> The recent introduction of insert inspired me to finally add a feature I've\r
+> >> been wanting: a command to index a specific file in the maildir. My usecase\r
+> >> for this is that I have an inotify-based script that watches for new mail\r
+> >> and calls notmuch new when new mail shows up. Running notmuch new in this\r
+> >> situation is overkill, since I know exactly what's changed. A faster command\r
+> >> that just adds a single file reduces contention on the database lock.\r
+> >>\r
+> >> This series introduces a new command, "notmuch add", which indexes a file\r
+> >> that already exists in the maildir. It is implemented in notmuch-insert.c\r
+> >> because it uses the basic infrastructure introduced for the insert command.\r
+> >>\r
+> >> Missing man page for now - wanted to get the code out first for review.\r
+> >\r
+> > Hey, Adam.  This feature seems fine, but it seems similar enought to\r
+> > insert that I wonder if they can just be unified.  What if insert just\r
+> > took an optional path argument as well, e.g.:\r
+> >\r
+> >   notmuch insert [options] [ +<tag>|-<tag> ... ] [-- /path/to/file]\r
+> >\r
+> > If the path is not in the db, it would insert it the same as if it had\r
+> > come in via stdin.  If the path *is* in the db, it could just do the add\r
+> > part that you're looking for.  That seems like it might be a more\r
+> > intuitive UI experience to me.\r
+> \r
+> I sort of agree but wonder if it would be more natural under "new" than\r
+> "insert". so notmuch new /path/to/file just adds that file (provided it\r
+> is in the database; perhaps a relative path?) This would also be\r
+> extensible to do a whole mail sub-directory which seems like it might\r
+> also be a useful feature. (I am definitely not saying that this needs to\r
+> be implemented now!)\r
+\r
+That would be mostly welcome addition indeed ...\r
+\r
+Cheers\r
+-- \r
+       Vlad\r