Re: [PATCH] libnotmuch: fix typo in CLEAN setting, add file

diff --git a/24/b3af8fe16573addb37d0205cda30ecdeba4a9b b/24/b3af8fe16573addb37d0205cda30ecdeba4a9b
new file mode 100644 (file)
index 0000000..e4d14a6
--- /dev/null
+++ b/24/b3af8fe16573addb37d0205cda30ecdeba4a9b
@@ -0,0 +1,110 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 24242431FD0\r
+       for <notmuch@notmuchmail.org>; Fri, 24 Jun 2011 10:52:01 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id R-r6bLRvcb+C for <notmuch@notmuchmail.org>;\r
+       Fri, 24 Jun 2011 10:52:00 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5F6E8431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 24 Jun 2011 10:52:00 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id E4CC029A608;\r
+       Fri, 24 Jun 2011 10:51:58 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id D0705254157; Fri, 24 Jun 2011 10:51:58 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] libnotmuch: fix typo in CLEAN setting, add file\r
+In-Reply-To: <1308912824-1709-1-git-send-email-david@tethera.net>\r
+References: <1308912824-1709-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Fri, 24 Jun 2011 10:51:51 -0700\r
+Message-ID: <87aad7ce2w.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 24 Jun 2011 17:52:01 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Fri, 24 Jun 2011 07:53:44 -0300, david@tethera.net wrote:\r
+> From: David Bremner <bremner@debian.org>\r
+\r
+Hi David,\r
+\r
+Thanks for the fix. A couple of nit-picky comments on the commit itself\r
+first:\r
+\r
+> - c0961e6 introduced a missing slash and\r
+> - cdf1c70a created a file and neglected to add it to clean\r
+\r
+I'd put a little more detail in the commit message here:\r
+\r
+=2D c0961e6 introduced a missing slash $(dir)$(LIBNAME)\r
+=2D cdf1c70a created $(dir)/notmuch.h.gch and neglected to add it to clean\r
+\r
+> The former seems to have been harmless, so maybe someone (Carl?) can\r
+> check if $(dir)/$(LIBNAME) really needs to be removed?\r
+\r
+This auxiliary text should be below the "---" line in the email so that\r
+it won't be in the commit message after I do "git am". (As is, I'd have\r
+to do extra work to "git commit --amend" this text away).\r
+\r
+As for the actual question, yes, $(dir)/$(LIBNAME) is supposed to be\r
+cleaned and is not getting cleaned. I've got libnotmuch.so.1.{1,2,3,4}.0\r
+all sitting around never cleaned.\r
+\r
+> -CLEAN :=3D $(CLEAN) $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINK=\r
+ER_NAME) $(dir)$(LIBNAME) libnotmuch.a notmuch.aux notmuch.sym\r
+> +CLEAN +=3D $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINKER_NAME)\r
+> +CLEAN +=3D $(dir)/$(LIBNAME) libnotmuch.a notmuch.aux notmuch.sym=20\r
+\r
+Meanwhile, I notice now that "libnotmuch.a" is also wrong, (should be\r
+"$(dir)/libnotmuch.a).\r
+\r
+Clearly we could use some testing of our "make clean" target to ensure\r
+it actually works. Does the Debian stuff not test anything like this?\r
+(Maybe I'm thinking of typical testing done by autoconf/automake's "make\r
+distcheck" that we haven't replicated yet.)\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk4EzrcACgkQ6JDdNq8qSWgK7ACfU/seIsV4PHvqjyhyxk0jB3AM\r
+75sAnjKkjX+Ccn+Z0Nydp0LaMcziXh2N\r
+=Vmdn\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r