pathspec: drop "lone : means no pathspec" from get_pathspec()

We may want to give the pathspec subsystem such a feature, but not while
we are still using get_pathspec() that returns a stupid "char **" that
loses subtle nuances that existed in the input string.

In the meantime, the callers of get_pathspec() that want to support it
could do an equivalent before feeding their argv[] to the function
themselves quite easily.

Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/setup.c b/setup.c
index 5048252d78638c2c6adcf8807442728ef4f37a5e..84f71d5ee0e2eebac0be67660590874d4d4dd24d 100644 (file)
--- a/setup.c
+++ b/setup.c
@@ -197,9 +197,6 @@ const char *prefix_pathspec(const char *prefix, int prefixlen, const char *elt)
                }
                if (*copyfrom == ')')
                        copyfrom++;
-       } else if (!elt[1]) {
-               /* Just ':' -- no element! */
-               return NULL;
        } else {
                /* shorthand */
                for (copyfrom = elt + 1;