Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message

diff --git a/0f/bba2135936ee51cd8df495cb59025569e6adee b/0f/bba2135936ee51cd8df495cb59025569e6adee
new file mode 100644 (file)
index 0000000..eba6571
--- /dev/null
+++ b/0f/bba2135936ee51cd8df495cb59025569e6adee
@@ -0,0 +1,74 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A0833431FBC\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 23:04:43 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id cMnJRieRIst7 for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Oct 2014 23:04:39 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id EA6BD431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 23:04:38 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Xb1PQ-0004DC-Ng; Mon, 06 Oct 2014 03:04:36 -0300\r
+Received: (nullmailer pid 18042 invoked by uid 1000); Mon, 06 Oct 2014\r
+       06:04:30 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <aclements@csail.mit.edu>\r
+Subject: Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message\r
+In-Reply-To: <20141005232008.GB7970@csail.mit.edu>\r
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+       <1412345958-8278-3-git-send-email-aclements@csail.mit.edu>\r
+       <87k34fot7d.fsf@maritornes.cs.unb.ca>\r
+       <20141005232008.GB7970@csail.mit.edu>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 06 Oct 2014 08:04:30 +0200\r
+Message-ID: <871tqlpwcx.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Oct 2014 06:04:43 -0000\r
+\r
+Austin Clements <aclements@csail.mit.edu> writes:\r
+\r
+> Quoth David Bremner on Oct 05 at  9:45 am:\r
+>> Austin Clements <aclements@csail.mit.edu> writes:\r
+>> > +    void *local = talloc_new (NULL);\r
+>> \r
+>> What's the advantage of using a local talloc context here? Is this just\r
+>> an optimization?\r
+>\r
+> There are a few allocations that wind up going in to this local\r
+> context because of the call to _consume_metadata_thread_id, so it's\r
+> more convenient to free this one context on return from\r
+> _notmuch_database_link_message than to worry about tracking these\r
+> various allocations.\r
+\r
+OK, but wouldn't the lazy solution be to use message as a talloc\r
+context?\r
+\r
+d\r