Re: cli: add --include-html option to notmuch show
authorJani Nikula <jani@nikula.org>
Sat, 24 Aug 2013 10:59:20 +0000 (13:59 +0300)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:56:37 +0000 (09:56 -0800)
7f/6990a5dcefd1bb70aaeb4ef48df307d6a0d7ac [new file with mode: 0644]

diff --git a/7f/6990a5dcefd1bb70aaeb4ef48df307d6a0d7ac b/7f/6990a5dcefd1bb70aaeb4ef48df307d6a0d7ac
new file mode 100644 (file)
index 0000000..602e0eb
--- /dev/null
@@ -0,0 +1,107 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4647B431FD7\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Aug 2013 03:59:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id L8cDOJHbhXR9 for <notmuch@notmuchmail.org>;\r
+       Sat, 24 Aug 2013 03:59:19 -0700 (PDT)\r
+Received: from mail-bk0-f46.google.com (mail-bk0-f46.google.com\r
+       [209.85.214.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 9E83F431FBD\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Aug 2013 03:59:19 -0700 (PDT)\r
+Received: by mail-bk0-f46.google.com with SMTP id 6so560434bkj.33\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Aug 2013 03:59:18 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=tGB+tZUWFjxNfCnJz91kgJpQLj7C4DE+rcrn1sFxmzo=;\r
+       b=NmhFVyiZ60XJC2Z+0tfpRPTpIViMjUVw4p3HWlWik+OtLqYnkjM3U26r+mGwr7HDfz\r
+       nStSIJZi4+kGJtnKvQVgUWhnwMdosVjoJgYOEQvU1MnZun2TUoCGWJk1gnbYjFu02sq2\r
+       fgXwVxX15oEzmkD3YaaPJsbLNjwRLgfmD5xIEQBuVVBw2SystuULKDzUAFMphcRUG0ZE\r
+       xcVA2TdBTId2GjjYtJTcg0GWPXoQzhxrWT6vJ+vqQJBTuS46ZLGgCWNNSiL3BeJR46Yc\r
+       g8DGWV1Hxr4t7bP3Sz8zdZzRof2YBD/cGitQvcaYie9M5uYGuhIS0CgUCcDcTLnep8by\r
+       kk9A==\r
+X-Gm-Message-State:\r
+ ALoCoQnJC3P7Ek03v0In1kwM6gZ1zKpuWgakHfiAlaEDJzicFDqtJNGxLhp2L52UlOExEdsNg1Cz\r
+X-Received: by 10.204.69.12 with SMTP id x12mr2877894bki.14.1377341958283;\r
+       Sat, 24 Aug 2013 03:59:18 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.\r
+       [88.195.111.91])\r
+       by mx.google.com with ESMTPSA id jh13sm817908bkb.13.1969.12.31.16.00.00\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sat, 24 Aug 2013 03:59:17 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, John Lenz <lenz@math.uic.edu>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: cli: add --include-html option to notmuch show\r
+In-Reply-To: <m2wqni7swv.fsf@guru.guru-group.fi>\r
+References: <notmuch-web-1372724382.450184839@www.wuzzeb.org>\r
+       <m27ggj1x29.fsf@guru.guru-group.fi>\r
+       <notmuch-web-1374719771.1588310986@www.wuzzeb.org>\r
+       <m2zjsxs0g1.fsf@guru.guru-group.fi>\r
+       <notmuch-web-1376754748.336647450@www.wuzzeb.org>\r
+       <87k3jjutpf.fsf@nikula.org> <m2wqni7swv.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16+10~g791e68f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 24 Aug 2013 13:59:20 +0300\r
+Message-ID: <878uzrnylz.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 24 Aug 2013 10:59:28 -0000\r
+\r
+On Sun, 18 Aug 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> Now, if we have --include-html should it be like that or \r
+> --include-html=(true|false). Currently we have both cases, adding\r
+> --verify, --decrypt, --create-folder, --batch, -no-hooks to the\r
+> set... I cannot get a clear opinion (without wast^H^H^H^H spending\r
+> excessive amount of time figuring these out) how this should be,\r
+> therefore I'm inclined to the opinion that\r
+>\r
+> the current patch from John with simple --include-html could be applied,\r
+> and in the future (if it is of anyone's interest) we update the parser\r
+> allowing boolean --arg equal --arg=true. Then it is just how we decide\r
+> to document these...\r
+\r
+The argument parser we have allows NOTMUCH_OPT_BOOLEAN options to be\r
+specified as --foo=(true|false) or simply --foo (for true). It is\r
+already now just a matter of documentation, and I'm sure we're not\r
+consistent.\r
+\r
+We also have things like --no-hooks in notmuch new. I added that, and in\r
+retrospect, that should be just --hooks=(true|false). I guess we left it\r
+like that because the default is true. Perhaps we should amend the\r
+argument parser to look for boolean option --foo if it encounters a\r
+--no-foo option.\r
+\r
+Why notmuch show has --exclude=(true|false) as a keyword option I don't\r
+quite grasp; the --entire-thread option at least has a special\r
+default. It might help some options if the parser had a way to tell if\r
+it's seen some option or not.\r
+\r
+Of course, none of this is really relevant to the patch in question!\r
+\r
+BR,\r
+Jani.\r