--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 1E3F3431FBD\r
+ for <notmuch@notmuchmail.org>; Mon, 10 Feb 2014 10:19:16 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Jo8m2eLcuR4x for <notmuch@notmuchmail.org>;\r
+ Mon, 10 Feb 2014 10:19:08 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu\r
+ [18.9.25.13])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 7EFEB431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 10 Feb 2014 10:19:08 -0800 (PST)\r
+X-AuditID: 1209190d-f79776d000000ce9-98-52f9181aea65\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+ (using TLS with cipher AES256-SHA (256/256 bits))\r
+ (Client did not present a certificate)\r
+ by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 47.FD.03305.A1819F25; Mon, 10 Feb 2014 13:19:06 -0500 (EST)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id s1AIJ52i020796; \r
+ Mon, 10 Feb 2014 13:19:06 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s1AIJ3Sp013979\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Mon, 10 Feb 2014 13:19:04 -0500\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1WCvRe-00025b-3v; Mon, 10 Feb 2014 13:19:02 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/7] emacs: tag: allow default case in notmuch-tag-formats\r
+In-Reply-To: <1390087855-26194-3-git-send-email-markwalters1009@gmail.com>\r
+References: <1390087855-26194-1-git-send-email-markwalters1009@gmail.com>\r
+ <1390087855-26194-3-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.17~rc2+14~g06f47e0 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Mon, 10 Feb 2014 13:19:01 -0500\r
+Message-ID: <87txc6n84q.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsUixG6noisl8TPI4OtnTYvVc3ksrt+cyezA\r
+ 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZcxa/o21YJ5cxbSvV1kaGOdLdDFycEgImEi8\r
+ uCbZxcgJZIpJXLi3nq2LkYtDSGA2k0TfiU/MEM5GRok7u6ZBZU4zSfya94EFwlnCKPFr61Mm\r
+ kH42AQ2JbfuXM4LYIgKuEk+/fWYGsYUF/CSWbd7IDmJzCnhJXDjUxA7R3M4o0bj8EViDqECS\r
+ xOmpv1lBbBYBVYkTE6eANfAC3bf91zRWCFtQ4uTMJywgNrOAlsSNfy+ZJjAKzEKSmoUktYCR\r
+ aRWjbEpulW5uYmZOcWqybnFyYl5eapGukV5uZoleakrpJkZQSHJK8u5gfHdQ6RCjAAejEg+v\r
+ xtcfQUKsiWXFlbmHGCU5mJREeXWFfwYJ8SXlp1RmJBZnxBeV5qQWH2KU4GBWEuGd+RKonDcl\r
+ sbIqtSgfJiXNwaIkzps4402QkEB6YklqdmpqQWoRTFaGg0NJgtdMHGioYFFqempFWmZOCUKa\r
+ iYMTZDgP0PB6kBre4oLE3OLMdIj8KUZFKXHeADGghABIIqM0D64XljJeMYoDvSLM6wnSzgNM\r
+ N3Ddr4AGMwENPtoEcnVxSSJCSqqBUeN1wpxn39k8FPpvGzxjsLid57M35E2kTOJXTT/pg15a\r
+ W7Rt8sx530gruZdG3Ky2+i5t7xCz7rbv/e2enC8T02KsA6axRUYsv984zUHk7OuL63vj/75+\r
+ tfqY1jb3Ekb+lOWKomvKZaPy1U5l+IuYT5zazV63cNmDP+FshivWPF5ek7RL9LWBEktxRqKh\r
+ FnNRcSIABITrH/QCAAA=\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 10 Feb 2014 18:19:16 -0000\r
+\r
+On Sat, 18 Jan 2014, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> Allow an empty string in notmuch-tag-formats which matches all tags\r
+> except those matched explicitly matched. This allows the user to tell\r
+\r
+Typo.\r
+\r
+> notmuch to hide all tags except those specified.\r
+>\r
+> This will be useful once formatting for deleted/added tags is added\r
+> later in the series: a user might want to hide all deleted tags for\r
+> example.\r
+> ---\r
+> emacs/notmuch-tag.el | 20 +++++++++++---------\r
+> 1 files changed, 11 insertions(+), 9 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el\r
+> index 2153068..92c1249 100644\r
+> --- a/emacs/notmuch-tag.el\r
+> +++ b/emacs/notmuch-tag.el\r
+> @@ -65,14 +65,15 @@\r
+> This gives a list that maps from tag names to lists of formatting\r
+> expressions. The car of each element gives a tag name and the\r
+> cdr gives a list of Elisp expressions that modify the tag. If\r
+> -the list is empty, the tag will simply be hidden. Otherwise,\r
+> -each expression will be evaluated in order: for the first\r
+> -expression, the variable `tag' will be bound to the tag name; for\r
+> -each later expression, the variable `tag' will be bound to the\r
+> -result of the previous expression. In this way, each expression\r
+> -can build on the formatting performed by the previous expression.\r
+> -The result of the last expression will displayed in place of the\r
+> -tag.\r
+> +the car is an empty string it matches all tags that do not have\r
+> +an explicit match. If the list is empty, the tag will simply be\r
+\r
+Hmm. I'm not sure I like overloading of the meanings of strings. Could\r
+we instead use a symbol to represent this case? For example, `t' would\r
+parallel the fall-through case of `cond' and `case', or `_' would\r
+parallel `pcase' [1]. Or even a separate variable like\r
+notmuch-tag-default-format?\r
+\r
+The former would require some tweaking of the customize widget, but that\r
+should probably happen anyway to support this special case.\r
+Unfortunately, we may need a custom alist widget variant to do that. (I\r
+tried and failed to tweak it in a way that both worked and looked\r
+decent.) Hence my suggestion of a separate variable, which would only\r
+require pulling out the :value-type into its own define-widget.\r
+\r
+I'm also slightly bothered that this would introduce a second way to\r
+control the default formatting of tags in addition to notmuch-tag-face,\r
+but only slightly.\r
+\r
+[1] It's unfortunate that pcase wasn't introduced until Emacs 24. I've\r
+been tempted to backport it for notmuch multiple times now. Then we\r
+could just treat notmuch-tag-formats as a list of pcase conditions.\r
+\r
+> +hidden. Otherwise, each expression will be evaluated in order:\r
+> +for the first expression, the variable `tag' will be bound to the\r
+> +tag name; for each later expression, the variable `tag' will be\r
+> +bound to the result of the previous expression. In this way,\r
+> +each expression can build on the formatting performed by the\r
+> +previous expression. The result of the last expression will\r
+> +displayed in place of the tag.\r
+> \r
+> For example, to replace a tag with another string, simply use\r
+> that string as a formatting expression. To change the foreground\r
+> @@ -140,7 +141,8 @@ This can be used with `notmuch-tag-format-image-data'."\r
+> \r
+> (defun notmuch-tag-format-tag (tag)\r
+> "Format TAG by looking into `notmuch-tag-formats'."\r
+> - (let ((formats (assoc tag notmuch-tag-formats)))\r
+> + (let ((formats (or (assoc tag notmuch-tag-formats)\r
+> + (assoc "" notmuch-tag-formats))))\r
+> (cond\r
+> ((null formats) ;; - Tag not in `notmuch-tag-formats',\r
+> tag) ;; the format is the tag itself.\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff