Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6

diff --git a/fa/4125db8ce7173957b2fea4155a5523f3a1631c b/fa/4125db8ce7173957b2fea4155a5523f3a1631c
new file mode 100644 (file)
index 0000000..9220951
--- /dev/null
+++ b/fa/4125db8ce7173957b2fea4155a5523f3a1631c
@@ -0,0 +1,93 @@
+Return-Path: <tomi.ollila@nixu.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 82CC1429E35\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 04:48:39 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 7z-9RlAimlUy for <notmuch@notmuchmail.org>;\r
+       Tue, 17 Jan 2012 04:48:37 -0800 (PST)\r
+Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6FB3B429E2F\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 04:48:37 -0800 (PST)\r
+Received: from pps.filterd (mail-gw3 [127.0.0.1])\r
+       by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q0HCljvM012427;\r
+       Tue, 17 Jan 2012 14:48:35 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by mail-gw3.nixu.fi with ESMTP id 114cs17tdf-1\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Tue, 17 Jan 2012 14:48:35 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
+       q0HCmY9n001667; Tue, 17 Jan 2012 14:48:35 +0200\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6\r
+In-Reply-To: <1326797453-9405-2-git-send-email-schnouki@schnouki.net>\r
+References: <8739bea9lc.fsf@thor.loria.fr>\r
+       <1326797453-9405-1-git-send-email-schnouki@schnouki.net>\r
+       <1326797453-9405-2-git-send-email-schnouki@schnouki.net>\r
+User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 17 Jan 2012 14:48:34 +0200\r
+Message-ID: <yf6lip65wbh.fsf@taco2.nixu.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,\r
+ 1.0.211,      0.0.0000        definitions=2012-01-17_02:2012-01-17, 2012-01-17,\r
+       1970-01-01 signatures=0\r
+X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
+       ipscore=0 suspectscore=3\r
+       phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0\r
+       reason=mlx\r
+       scancount=1 engine=6.0.2-1012030000 definitions=main-1201170076\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Jan 2012 12:48:39 -0000\r
+\r
+On Tue, 17 Jan 2012 11:50:53 +0100, Thomas Jost <schnouki@schnouki.net> wrote:\r
+> There are lots of API changes in gmime 2.6 crypto handling. By adding\r
+> preprocessor directives, it is however possible to add gmime 2.6 compatibility\r
+> while preserving compatibility with gmime 2.4 too.\r
+> \r
+> This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info".\r
+> \r
+> This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31, the\r
+> crypto tests all work fine (as expected). With gmime 2.6.4, one crypto test\r
+> fails (signature verification with signer key unavailable) but this will be hard\r
+> to fix since the new API does not report the reason why a signature verification\r
+> fails (other than the human-readable error message).\r
+> ---\r
+\r
+LGTM. Some whitespace things but most of those were there already;\r
+I'd have one uncrustify round to be applied to the source and after\r
+that be more strict about those...\r
+\r
+actually gmime 2.4 has GMIME_CHECK_VERSION defined as\r
+g_mime_check_version (major, minor, micro) so the comment about it\r
+is not entirely accurate (it is unusable in our context, though)\r
+\r
+\r
+Tomi\r