Re: [PATCH] configure: Add sanity checking for environment variables

diff --git a/40/efa577c77847a8d68910238a2a326012c0ffac b/40/efa577c77847a8d68910238a2a326012c0ffac
new file mode 100644 (file)
index 0000000..7b1094d
--- /dev/null
+++ b/40/efa577c77847a8d68910238a2a326012c0ffac
@@ -0,0 +1,141 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 38DFC6DE1A04\r
+ for <notmuch@notmuchmail.org>; Wed, 20 May 2015 01:41:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.046\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.046 tagged_above=-999 required=5 tests=[AWL=0.394, \r
+ SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Fud69E2HgW7Y for <notmuch@notmuchmail.org>;\r
+ Wed, 20 May 2015 01:41:30 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 073B86DE19F6\r
+ for <notmuch@notmuchmail.org>; Wed, 20 May 2015 01:41:30 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 54D361000F2;\r
+ Wed, 20 May 2015 11:41:08 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, David Bremner <david@tethera.net>,\r
+ Ronny Chevalier <chevalier.ronny@gmail.com>\r
+Subject: Re: [PATCH] configure: Add sanity checking for environment variables\r
+In-Reply-To: <m2oalftzjr.fsf@guru.guru-group.fi>\r
+References: <m2617onuhh.fsf@guru.guru-group.fi>\r
+ <1432109551-16861-1-git-send-email-david@tethera.net>\r
+ <m2oalftzjr.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.19+115~g9a981cb (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 20 May 2015 11:41:08 +0300\r
+Message-ID: <m2twv77iaj.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 20 May 2015 08:41:32 -0000\r
+\r
+On Wed, May 20 2015, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+\r
+> On Wed, May 20 2015, David Bremner <david@tethera.net> wrote:\r
+>\r
+>> Passing in environment variables incompatible with the compiler may\r
+>> cause other parts of the configure script to fail in hard to\r
+>> understand ways, so we abort early.\r
+>> ---\r
+>>\r
+>> meh, the previous version was borken by lazy evaluation of CXXFLAGS\r
+>> using make syntax. Better suggestions for how to do this?\r
+>>\r
+>>  configure | 31 +++++++++++++++++++++++++++++--\r
+>>  1 file changed, 29 insertions(+), 2 deletions(-)\r
+>>\r
+>> diff --git a/configure b/configure\r
+>> index 4af7ba9..650b976 100755\r
+>> --- a/configure\r
+>> +++ b/configure\r
+>> @@ -269,6 +269,35 @@ dependencies are available:\r
+>>  EOF\r
+>>  \r
+>>  errors=0\r
+>> +printf "int main(void){return 0;}\n" > minimal.c\r
+>> +\r
+>> +printf "Sanity checking C compilation environment... "\r
+>> +if ${CC} ${CFLAGS} ${CPPFLAGS}  minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1\r
+>\r
+> still 2 spaces  ----------------^\r
+>\r
+>> +then\r
+>> +    printf "OK.\n"\r
+>> +else\r
+>> +    printf "Fail.\n"\r
+>> +    errors=$((errors + 1))\r
+>> +fi\r
+>> +\r
+>> +printf "Sanity checking C++ compilation environment... "\r
+>> +if ${CXX} ${CXXFLAGS_for_sh} ${CPPFLAGS} minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1\r
+>\r
+> ${CXXFLAGS:-$CFLAGS} ?\r
+\r
+of course not... I did not find any definition for CXXFLAGS_for_sh....\r
+... so\r
+\r
+case $CXXFLAGS \r
+       in *'(CFLAGS)'*) CXXFLAGS_for_sh=$CFLAGS \r
+       ;; *) CXXFLAGS_for_sh=CXXFLAGS\r
+esac\r
+\r
+\r
+>\r
+>> +then\r
+>> +    printf "OK.\n"\r
+>> +else\r
+>> +    printf "Fail.\n"\r
+>> +    errors=$((errors + 1))\r
+>> +fi\r
+>> +\r
+>> +if [ $errors -gt 0 ]; then\r
+>> +    cat <<EOF\r
+>> +*** Error: Initial sanity checking of environment failed.  Please try\r
+>> +running configure in a clean environment, and if the problem persists,\r
+>> +report a bug.\r
+>> +EOF\r
+>> +    rm -f minimal minimal.c\r
+>> +    exit 1\r
+>> +fi\r
+>>  \r
+>>  if pkg-config --version > /dev/null 2>&1; then\r
+>>      have_pkg_config=1\r
+>> @@ -690,8 +719,6 @@ else\r
+>>  fi\r
+>>  rm -f compat/check_asctime\r
+>>  \r
+>> -printf "int main(void){return 0;}\n" > minimal.c\r
+>> -\r
+>>  printf "Checking for rpath support... "\r
+>>  if ${CC} -Wl,--enable-new-dtags -Wl,-rpath,/tmp/ -o minimal minimal.c >/dev/null 2>&1\r
+>>  then\r
+>> -- \r
+>> 2.1.4\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r