Re: [PATCH 00/11] notmuch insert updates

diff --git a/06/fd92d10e8f6fb43e65980810beb654e8be8ced b/06/fd92d10e8f6fb43e65980810beb654e8be8ced
new file mode 100644 (file)
index 0000000..65b83c0
--- /dev/null
+++ b/06/fd92d10e8f6fb43e65980810beb654e8be8ced
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1C856431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Sep 2014 12:55:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id b-yoN5IqUFXg for <notmuch@notmuchmail.org>;\r
+       Thu, 25 Sep 2014 12:55:04 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id A9914431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Sep 2014 12:55:04 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id EF39D100033;\r
+       Thu, 25 Sep 2014 22:54:53 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] notmuch insert updates\r
+In-Reply-To: <878ul815jf.fsf@maritornes.cs.unb.ca>\r
+References: <cover.1411379395.git.jani@nikula.org>\r
+       <878ul815jf.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.18.1+97~g6c845ef (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 25 Sep 2014 22:54:53 +0300\r
+Message-ID: <m24mvvpjaq.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 25 Sep 2014 19:55:10 -0000\r
+\r
+On Thu, Sep 25 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>> This series refactors and cleans up insert, improves error handling and\r
+>> reporting, and adds post-insert hook. I intend to add documentation and\r
+>> more tests, but the code is ready for review. Also, at least some of the\r
+>> cleanups and fixes in the beginning of the series could go in without\r
+>> additional tests or documentation.\r
+>\r
+> The first 4 seem trivial, and I marked them so.\r
+>\r
+> 5-8 don't introduce new functionality, and don't break \r
+> any existing tests. Subject to a little more review, these could \r
+> probably be merged now.\r
+>\r
+> 5 is almost trivial; it wouldn't hurt to explicitly document the return\r
+> values of sync_dir, while touching this code.\r
+>\r
+> 6 and 8 seem ok, but should probably have another pair of eyes.\r
+>\r
+> 7 seems ok. At first I worried about the usual issue of races between\r
+> name definition and open, but it seems like nothing changes here.\r
+\r
+5-8 in this series LGTM.\r
+\r
+Tomi\r
+\r