Re: [PATCH] Add a defcustom for whether to block remote images by default.

diff --git a/6a/1a50893fe43034c6ed0d73e62f268e8eb19c10 b/6a/1a50893fe43034c6ed0d73e62f268e8eb19c10
new file mode 100644 (file)
index 0000000..a852f7e
--- /dev/null
+++ b/6a/1a50893fe43034c6ed0d73e62f268e8eb19c10
@@ -0,0 +1,149 @@
+Return-Path: <jinwoo68@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 02315431FC4\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Jan 2015 12:57:21 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.639\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.639 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       DNS_FROM_AHBL_RHSBL=2.438, FREEMAIL_ENVFROM_END_DIGIT=1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5P4cOkqLxE9u for <notmuch@notmuchmail.org>;\r
+       Thu, 29 Jan 2015 12:57:18 -0800 (PST)\r
+Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com\r
+       [209.85.220.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4FB4C431FBC\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Jan 2015 12:57:18 -0800 (PST)\r
+Received: by mail-pa0-f41.google.com with SMTP id kq14so43466183pab.0\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Jan 2015 12:57:17 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=a+/W2XR96WoBZymwOdoEpTm4q6g5/hbTj4k2Z+hMlvo=;\r
+       b=RRtVXcCP0Oat/R4JGfD8iZ4tsKHbO7QXo+h1dOeVz9d27xWwfal89bGCE+QB9di1Eg\r
+       sjERZbO+CX5c/YAnmTuTzZAOZqrTvoBGx8yI1Op+IH1RW9/tUx0wvJidYMDEt2mPFrqm\r
+       PKgJXHCx0tHy7sQ4UewUvujpHCbFg3uP1auFVe3f+k/1MtNE1PZum8jZ/YcXETYjlgWe\r
+       HmI61d0Bcuyra0JYLmoJvAeFO9q1PXhUXYrgr8uKGqlsIfn/2Z5KrJV/EvddQNq5ur2C\r
+       GCLKih2NSK63G3yHtwlUhuHx4df5KeMXjDPMCY/8Q30O0txo+nTHkOtD7hHfmi1sOQwo\r
+       g3ag==\r
+X-Received: by 10.70.93.97 with SMTP id ct1mr3567370pdb.71.1422565036991;\r
+       Thu, 29 Jan 2015 12:57:16 -0800 (PST)\r
+Received: from localhost ([24.130.61.213])\r
+       by mx.google.com with ESMTPSA id tu7sm8757187pac.6.2015.01.29.12.57.16\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Thu, 29 Jan 2015 12:57:16 -0800 (PST)\r
+From: Jinwoo Lee <jinwoo68@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, David Bremner <david@tethera.net>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Add a defcustom for whether to block remote images by\r
+       default.\r
+In-Reply-To: <m2bnlh8hck.fsf@guru.guru-group.fi>\r
+References: <1422495572-40384-1-git-send-email-jinwoo68@gmail.com>\r
+       <87pp9yjbhw.fsf@maritornes.cs.unb.ca>\r
+       <m2sieut13t.fsf@guru.guru-group.fi>\r
+       <yq65mw51h4td.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+       <m2bnlh8hck.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-apple-darwin13.2.0)\r
+Date: Thu, 29 Jan 2015 12:57:14 -0800\r
+Message-ID: <yq65egqds3th.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 29 Jan 2015 20:57:22 -0000\r
+\r
+On Thu, Jan 29, 2015 at 12:25 PM, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Thu, Jan 29 2015, Jinwoo Lee <jinwoo68@gmail.com> wrote:\r
+>\r
+>> On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+>>> On Thu, Jan 29 2015, David Bremner <david@tethera.net> wrote:\r
+>>>\r
+>>>> Jinwoo Lee <jinwoo68@gmail.com> writes:\r
+>>>>\r
+>>>>> +        (shr-blocked-images (if notmuch-show-block-remote-images\r
+>>>>> +                                "."\r
+>>>>> +                              shr-blocked-images)))\r
+>>>>>      (shr-insert-document dom)\r
+>>>>>      t))\r
+>>>>\r
+>>>> Ideally such a customization would apply to all html renders. I think\r
+>>>> Tomi did some experiments with w3m and friends, I _think_ they respect\r
+>>>> gnus-blocked-images, but maybe Tomi can comment.\r
+>>>\r
+>>> I did M-x debug-on-entry RET open-network-stream RET  (or an equivalent of\r
+>>> t that in elisp, but the code I did is now lost & forgotten ;/\r
+>>>\r
+>>> The docstring relevant to the renderers below it at the end of this email.\r
+>>>\r
+>>> 'gnus-w3m respect gnus-blocked-images\r
+>>>\r
+>>> I could not run 'w3m on that system... nor 'w3\r
+>>>\r
+>>> There was no effect with 'w3m-standalone -- in this case I'd think it is up\r
+>>> to w3m binary to load external stuff or not. I presume the same is the\r
+>>> case with 'links, 'lynx, 'html2text and nil\r
+>>>\r
+>>> So, to add to David's suggestion maybe just set both gnus-blocked-images\r
+>>> and shr-blocked-images to the value of\r
+>>> notmuch-show-text/html-blocked-images\r
+>>\r
+>> All right.  I sent another patch that does this.  Thanks, guys!\r
+>\r
+> Thanks for your contribution. You seem to have taken my suggestion\r
+> literally just that it IIRC now only sets those when using shr renderer --\r
+> setting of gnus-blocked images should be in other code path... i am not\r
+> sure though i am sending this using mobile phi0one terminal and checking\r
+> for sure is just too PITA ;\\r
+\r
+Ouch.  I was stupid.  I'll send an update soon.\r
+\r
+>\r
+> Tomi\r
+>\r
+>>\r
+>>>\r
+>>>\r
+>>> Tomi\r
+>>>\r
+>>>\r
+>>> mm-text-html-renderer is a variable defined in `mm-decode.el'.\r
+>>> Its value is shr\r
+>>>\r
+>>> Documentation:\r
+>>> Render of HTML contents.\r
+>>> It is one of defined renderer types, or a rendering function.\r
+>>> The defined renderer types are:\r
+>>> `shr': use the built-in Gnus HTML renderer;\r
+>>> `gnus-w3m': use Gnus renderer based on w3m;\r
+>>> `w3m': use emacs-w3m;\r
+>>> `w3m-standalone': use plain w3m;\r
+>>> `links': use links;\r
+>>> `lynx': use lynx;\r
+>>> `w3': use Emacs/W3;\r
+>>> `html2text': use html2text;\r
+>>> nil    : use external viewer (default web browser).\r
+>>>\r
+>>>\r
+>>>> d\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r