Re: notmuch sha1 implementation broken on (some) big-endian architectures

diff --git a/d9/3ebe99c472faf28dfb354244412e527e9b49bb b/d9/3ebe99c472faf28dfb354244412e527e9b49bb
new file mode 100644 (file)
index 0000000..32496c5
--- /dev/null
+++ b/d9/3ebe99c472faf28dfb354244412e527e9b49bb
@@ -0,0 +1,86 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 286F7431FC3\r
+       for <notmuch@notmuchmail.org>; Sun, 24 Nov 2013 04:40:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id dbLy3H6rEdLq for <notmuch@notmuchmail.org>;\r
+       Sun, 24 Nov 2013 04:40:22 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E6A86431FBF\r
+       for <notmuch@notmuchmail.org>; Sun, 24 Nov 2013 04:40:21 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VkYz2-0006xt-OJ; Sun, 24 Nov 2013 08:40:16 -0400\r
+Received: (nullmailer pid 4921 invoked by uid 1000); Sun, 24 Nov 2013\r
+       12:40:13 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: notmuch sha1 implementation broken on (some) big-endian\r
+       architectures\r
+In-Reply-To: <87eh666mhp.fsf@zancas.localnet>\r
+References: <87eh666mhp.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.17~rc1 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 24 Nov 2013 08:40:13 -0400\r
+Message-ID: <87bo1a6kia.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 24 Nov 2013 12:40:26 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> The following code, when linked with libnotmuch.a and libutil.a does a\r
+> passable imitation of sha1sum on amd64 (and I guess also i386) but\r
+> computes a different digest on powerpc and probably sparc and s390x.\r
+>\r
+> In the long run we should maybe outsource hash computations to\r
+> e.g. librhash, but I'd like a simpler fix for 0.17, if possible\r
+\r
+Out of curiousity, I tried out a similar example with librhash, and it\r
+works fine on powerpc.\r
+\r
+#include <errno.h>\r
+#include "rhash.h" /* LibRHash interface */\r
+\r
+int main(int argc, char *argv[])\r
+{\r
+  char digest[64];\r
+  char output[130];\r
+\r
+  rhash_library_init(); /* initialize static data */\r
+\r
+  int res = rhash_file(RHASH_SHA1, argv[1], digest);\r
+  if(res < 0) {\r
+    fprintf(stderr, "LibRHash error: %s: %s\n", argv[1], strerror(errno));\r
+    return 1;\r
+  }\r
+\r
+  /* convert binary digest to hexadecimal string */\r
+  rhash_print_bytes(output, digest, rhash_get_digest_size(RHASH_SHA1),RHPR_HEX);\r
+\r
+  printf("%s (%s) = %s\n", rhash_get_name(RHASH_SHA1), argv[1], output);\r
+  return 0;\r
+}\r