Re: [PATCH] test: optionally print subtest number

diff --git a/a6/80642cd8f2fd769f294663275aa11631298abd b/a6/80642cd8f2fd769f294663275aa11631298abd
new file mode 100644 (file)
index 0000000..c7115ff
--- /dev/null
+++ b/a6/80642cd8f2fd769f294663275aa11631298abd
@@ -0,0 +1,111 @@
+Return-Path: <tomi.ollila@nixu.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9AE11431FD0\r
+       for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 06:05:08 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id K1V7ihFGKpdD for <notmuch@notmuchmail.org>;\r
+       Sat, 17 Dec 2011 06:05:08 -0800 (PST)\r
+Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D9D30431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 06:05:07 -0800 (PST)\r
+Received: from pps.filterd (mail-gw3 [127.0.0.1])\r
+       by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pBHE4M0g032072;\r
+       Sat, 17 Dec 2011 16:04:55 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by mail-gw3.nixu.fi with ESMTP id 114cs0u17u-1\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sat, 17 Dec 2011 16:04:54 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
+       pBHE4riR022831; Sat, 17 Dec 2011 16:04:54 +0200\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: optionally print subtest number\r
+In-Reply-To: <1323806207-31888-1-git-send-email-david@tethera.net>\r
+References: <1323806207-31888-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.10.2+93~g631d290 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 17 Dec 2011 16:04:53 +0200\r
+Message-ID: <yf6r50347lm.fsf@taco2.nixu.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,\r
+ 1.0.211,      0.0.0000        definitions=2011-12-17_01:2011-12-16, 2011-12-17,\r
+       1970-01-01 signatures=0\r
+X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
+       ipscore=0 suspectscore=0\r
+       phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0\r
+       reason=mlx\r
+       scancount=1 engine=6.0.2-1012030000 definitions=main-1112170109\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 17 Dec 2011 14:05:08 -0000\r
+\r
+On Tue, 13 Dec 2011 15:56:47 -0400, David Bremner <david@tethera.net> wrote:\r
+> From: David Bremner <bremner@debian.org>\r
+> \r
+> The idea is that $test_count could be used in tests to label\r
+> intermediate files. The output enabled by this patch (and --debug)\r
+> helps figure out which OUTPUT.nn file belongs to which test in case\r
+> several subtests write to OUTPUT.$test_count\r
+> ---\r
+> \r
+> Is there something that depends on the test format? I find it pretty\r
+> handy to have the subtest numbers, but I don't want to break some\r
+> other tools. I followed the existing style of conditionally defining\r
+> functions, but maybe someone with more bash-fu can improve that.\r
+> \r
+>  test/test-lib.sh |   12 ++++++++++++\r
+>  1 files changed, 12 insertions(+), 0 deletions(-)\r
+> \r
+> diff --git a/test/test-lib.sh b/test/test-lib.sh\r
+> index 6be93fe..aaaaf5c 100644\r
+> --- a/test/test-lib.sh\r
+> +++ b/test/test-lib.sh\r
+> @@ -116,6 +116,16 @@ do\r
+>      esac\r
+>  done\r
+>  \r
+> +if test -n "$debug"; then\r
+> +    print_subtest () {\r
+> +    printf "\t[%d]\t" $(($test_count - 1))\r
+\r
+Like this, as iterated by Dmitry & me\r
+\r
+       printf " %-4s" "[$(($test_count - 1))]"\r
+(or\r
+       printf " %-4s" "[$((test_count - 1))]"\r
+)\r
+\r
+I think this is very useful feature; When searching reasons why\r
+test failed the output files can be easily found as the test\r
+number is show on screen. Also, when debugging problems with \r
+users online in distant locations, passing around the test\r
+number in any particular moment eases the interaction considerably.\r
+\r
+Tomi\r