Re: [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body.

diff --git a/43/4213285cb0d99211ee3304e9da3cebe6439b45 b/43/4213285cb0d99211ee3304e9da3cebe6439b45
new file mode 100644 (file)
index 0000000..4f18f1a
--- /dev/null
+++ b/43/4213285cb0d99211ee3304e9da3cebe6439b45
@@ -0,0 +1,106 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B4345431FD0\r
+       for <notmuch@notmuchmail.org>; Fri,  9 Dec 2011 11:52:50 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ZPzba7njR6qG for <notmuch@notmuchmail.org>;\r
+       Fri,  9 Dec 2011 11:52:48 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
+       [18.7.68.37])\r
+       by olra.theworths.org (Postfix) with ESMTP id AECBE431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  9 Dec 2011 11:52:48 -0800 (PST)\r
+X-AuditID: 12074425-b7f116d0000008fe-86-4ee2671090ee\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 3C.5B.02302.01762EE4; Fri,  9 Dec 2011 14:52:48 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id pB9JqlBG032110; \r
+       Fri, 9 Dec 2011 14:52:48 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pB9JqjfV012192\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Fri, 9 Dec 2011 14:52:46 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1RZ6WY-0000K3-9j; Fri, 09 Dec 2011 14:54:26 -0500\r
+Date: Fri, 9 Dec 2011 14:54:26 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH 1/4] show: Pass notmuch_message_t instead of path to\r
+       show_message_body.\r
+Message-ID: <20111209195426.GJ3190@mit.edu>\r
+References: <1322446871-14986-1-git-send-email-amdragon@mit.edu>\r
+       <1323027100-10307-1-git-send-email-amdragon@mit.edu>\r
+       <1323027100-10307-2-git-send-email-amdragon@mit.edu>\r
+       <87ty597eh8.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87ty597eh8.fsf@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IRYrdT1xVIf+Rn0HFYwOLq1n52i+s3ZzI7\r
+       MHnsnHWX3ePZqlvMAUxRXDYpqTmZZalF+nYJXBm7e96zF5znqGh/s4m9gfEnWxcjJ4eEgInE\r
+       z71PWCBsMYkL99YDxbk4hAT2MUocnNfACOGsZ5RYurmBBcI5wSSxv2MPVNkSRolHT7cxgvSz\r
+       CKhIfJi0hQnEZhPQkNi2fzlYXETAUOLWxVfMIDazgLTEt9/NYDXCArESDRvug8V5BbQlDu/Z\r
+       wgox9DSjxMlNj9ggEoISJ2dCHMgsoCVx499LoGYOsEHL/3GAmJwC6hJbbzmBVIgCnTDl5Da2\r
+       CYxCs5A0z0LSPAuheQEj8ypG2ZTcKt3cxMyc4tRk3eLkxLy81CJdC73czBK91JTSTYzgwHZR\r
+       3cE44ZDSIUYBDkYlHl5Pr0d+QqyJZcWVuYcYJTmYlER541KAQnxJ+SmVGYnFGfFFpTmpxYcY\r
+       JTiYlUR4VeSBcrwpiZVVqUX5MClpDhYlcd6GXQ/9hATSE0tSs1NTC1KLYLIyHBxKErwBqUCN\r
+       gkWp6akVaZk5JQhpJg5OkOE8QMNDI0GGFxck5hZnpkPkTzEqSonzmoAkBEASGaV5cL2wxPOK\r
+       URzoFWFeJZAqHmDSgut+BTSYCWjwl+wHIINLEhFSUg2MjBeYzzTav72tc+/SQSNP1n8OH76m\r
+       PnsltDdq4stdt7z+LAl47eF5TVXq8MpJE2bWbwyxcaht1/wxe9r+X78PO33YV/2/8Gd2kPfc\r
+       5Iim5Cm8Ft+vFF07KVa3N+PF5kM3TRZaVLC/FzmvFSsw/+oSlRP/upu/ytmGP1D85VaTujfG\r
+       X3Bq16fdHUosxRmJhlrMRcWJADh+3DsXAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 09 Dec 2011 19:52:50 -0000\r
+\r
+Quoth Dmitry Kurochkin on Dec 09 at 11:05 pm:\r
+> On Sun,  4 Dec 2011 14:31:37 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> >  }\r
+> >  \r
+> >  notmuch_status_t\r
+> > -show_message_body (const char *filename,\r
+> > +show_message_body (notmuch_message_t *message,\r
+> >               const notmuch_show_format_t *format,\r
+> >               notmuch_show_params_t *params)\r
+> \r
+> Is show_message_body() (or functions that it calls/would call) supposed\r
+> to modify the message structure?  If not, we should make it const.\r
+\r
+That would be nice, but lack of const in libnotmuch makes it difficult\r
+to do this (for example, notmuch_message_get_filename, which\r
+show_message_body calls, takes a non-const notmuch_message_t *).\r
+\r
+OTOH, since functions like notmuch_message_get_filename lazily compute\r
+fields of notmuch_message_t and C has no equivalent of C++'s mutable,\r
+it's not clear making the message const is even the right thing to do.\r
+\r
+> I would also make all pointers constant (i.e. const notmuch_message_t\r
+> *const message), but I can not insist since it is not common in notmuch.\r
+> \r
+> Regards,\r
+>   Dmitry\r