Re: Linux-only fdatasync() in 3c13bc

diff --git a/5e/d5e4bf64bda262118fc2b1003bcbb23d85155b b/5e/d5e4bf64bda262118fc2b1003bcbb23d85155b
new file mode 100644 (file)
index 0000000..f38dd86
--- /dev/null
+++ b/5e/d5e4bf64bda262118fc2b1003bcbb23d85155b
@@ -0,0 +1,78 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A2600431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  7 May 2014 06:21:51 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Y9mbIvy-ncWd for <notmuch@notmuchmail.org>;\r
+       Wed,  7 May 2014 06:21:44 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 08655431FBD\r
+       for <notmuch@notmuchmail.org>; Wed,  7 May 2014 06:21:44 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1Wi1jt-0002sb-0l; Wed, 07 May 2014 13:18:25 +0000\r
+Received: (nullmailer pid 8176 invoked by uid 1000); Wed, 07 May 2014\r
+       13:17:58 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Kushal Kumaran\r
+       <kushal.kumaran+notmuch@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: Linux-only fdatasync() in 3c13bc\r
+In-Reply-To: <m27g5x7o4w.fsf@guru.guru-group.fi>\r
+References: <20140506195938.GA18213@coyotlan.Tlalpan>\r
+       <536a1723.0578e00a.601a.ffff976f@mx.google.com>\r
+       <m27g5x7o4w.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 07 May 2014 22:17:58 +0900\r
+Message-ID: <87vbthu3qx.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 07 May 2014 13:21:51 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> On Wed, May 07 2014, Kushal Kumaran <kushal.kumaran+notmuch@gmail.com> wr=\r
+ote:\r
+>\r
+>> X=C4=ABc=C3=B2 <xico@atelo.org> writes:\r
+>>\r
+>>> Also, commit 3c13bc introduced a call to fdatasync() which is not\r
+>>> available on FreeBSD, and probably not either on MacOS at least.\r
+>>>\r
+>>\r
+>> fdatasync is POSIX:\r
+>> http://pubs.opengroup.org/onlinepubs/009695399/functions/fdatasync.html\r
+>\r
+> No wonder it is problematic, then >;)\r
+>\r
+\r
+I seem to recall Austin saying on IRC that this usage was guaranteed to\r
+call fsync anyway. Comments Austin?\r
+\r
+d\r
+\r
+\r