Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()

diff --git a/ee/22b97ba933811d73b7808b4601c2b5d8223013 b/ee/22b97ba933811d73b7808b4601c2b5d8223013
new file mode 100644 (file)
index 0000000..f8fcb4b
--- /dev/null
+++ b/ee/22b97ba933811d73b7808b4601c2b5d8223013
@@ -0,0 +1,104 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1ABB6431FC0\r
+       for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:59:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id vQ7qcKnrnILK for <notmuch@notmuchmail.org>;\r
+       Tue, 21 May 2013 07:59:32 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id EB9CA431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:59:31 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 1537E1002C3;\r
+       Tue, 21 May 2013 17:59:31 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Ali Polatel <polatel@gmail.com>\r
+Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()\r
+In-Reply-To: <20130521144659.GA6002@hayalet>\r
+References: <1369052664-17869-1-git-send-email-felipe.contreras@gmail.com>\r
+       <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>\r
+       <m2vc6c4dtq.fsf@guru.guru-group.fi> <20130521144659.GA6002@hayalet>\r
+User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 21 May 2013 17:59:31 +0300\r
+Message-ID: <m2sj1g4bvw.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 21 May 2013 14:59:40 -0000\r
+\r
+On Tue, May 21 2013, Ali Polatel <polatel@gmail.com> wrote:\r
+\r
+> 2013/05/21 Tomi Ollila <tomi.ollila@iki.fi>:\r
+>>On Mon, May 20 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+>>\r
+>>> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are\r
+>>> loaded lazily, so nobody would notice unless they try\r
+>>> 'query::count_messages'.\r
+>>>\r
+>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\r
+>>\r
+>>This patch could be pushed on it's own, but someone (like Ali) could\r
+>>comment on the change as searches on both UINT2FIX() & UINT2NUM()\r
+>>provides (IMH) insatisfactory results...\r
+>\r
+> LGTM.\r
+>\r
+> My bad, there's no such thing as UINT2FIX().\r
+> Yet, what's wrong with UINT2NUM()?\r
+\r
+Nothing wrong -- although it seems obvious UINT2NUM() is the right thing\r
+to do I was not qualified to say so...\r
+\r
+>\r
+> The description looks like:\r
+> "...take an unsigned int and convert it to a FIXNUM object if it will fit;\r
+> otherwise, convert to a Bignum object..."\r
+\r
+... as I did not find this description when browsing the search results\r
+(now this was in the first search result -- sometimes one just doesn't\r
+get the right search terms in place)...\r
+\r
+>\r
+> Besides ruby-1.8 has it and that's the oldest version I was willing to\r
+> support. (If you have some free time, please confirm this because I may\r
+> not be remembering correctly.)\r
+\r
+Cannot confirm for sure -- I found references to UINT2NUM() and ruby\r
+1.8.6...\r
+\r
+.. anyway UINT2FIX() doesn't work and UINT2NUM() works with very high\r
+probablility I'd say lets get this pushed.\r
+\r
+"Hey, it compiles! Ship It !"\r
+\r
+>\r
+>>Tomi\r
+>\r
+>              -alip\r
+\r
+Tomi\r