Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps

diff --git a/cf/8522c89519fb5f74ac4e72fe66d05e2a91d52d b/cf/8522c89519fb5f74ac4e72fe66d05e2a91d52d
new file mode 100644 (file)
index 0000000..93dc707
--- /dev/null
+++ b/cf/8522c89519fb5f74ac4e72fe66d05e2a91d52d
@@ -0,0 +1,104 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EABD5431FC7\r
+       for <notmuch@notmuchmail.org>; Sun, 25 May 2014 10:01:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Mp3jYaA72+0K for <notmuch@notmuchmail.org>;\r
+       Sun, 25 May 2014 10:01:48 -0700 (PDT)\r
+Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com\r
+ [74.125.82.44])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 433B1431FAF   for <notmuch@notmuchmail.org>; Sun, 25 May 2014 10:01:48 -0700\r
+ (PDT)\r
+Received: by mail-wg0-f44.google.com with SMTP id a1so6824296wgh.3\r
+       for <notmuch@notmuchmail.org>; Sun, 25 May 2014 10:01:46 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:cc:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=fxEpk0jDCCdagO7ZguCRcLaCxOJb2hhCAgOhwkkAob4=;\r
+       b=MHH8GjUr2WBWAChKen5up+VsjwTQL3I+TpD156rpBZsH6tyLZKcXdDuh4hQx0hUkgA\r
+       FMyGzLHF0wwkxNngaO6voqvYOQ4m/uKWOIT3QcTS854mmBVmdszs0cCk1DbV2zNJ+iOa\r
+       VPbAWIbwaqTiGC8pf+NBjkfYDJn1Gd3ujs23znbLJcSwhM1ICZwXI69cT+lyxqnKeV1C\r
+       d3reGpSIF5gEmFz2hwm9ryx2vwuz3Qy0qymOcTDm0TDWdI6Fb9OJbdAUwKQT9/HahMnJ\r
+       9yueQga6nC5HKbjrf0oIQ2DbbwzHd/TgTg9Nt5SX9SYEUpZsnQvw3MpaApYoREzka/rw\r
+       7hUw==\r
+X-Gm-Message-State:\r
+ ALoCoQnN00QoVFeGwiAC7LkBl4j+T1SusUCvUOjm4UPa+8BcyxiY52GGzSJ91az7twfkEypWVUid\r
+X-Received: by 10.180.94.37 with SMTP id cz5mr20407955wib.19.1401037306867;\r
+       Sun, 25 May 2014 10:01:46 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.\r
+       [88.195.111.91])\r
+       by mx.google.com with ESMTPSA id b19sm19636522wic.5.2014.05.25.10.01.45\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Sun, 25 May 2014 10:01:46 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Felipe Contreras <felipe.contreras@gmail.com>,\r
+       Felipe Contreras <felipe.contreras@gmail.com>,\r
+       Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps\r
+In-Reply-To: <5382107e7870f_2275ff3304ec@nysa.notmuch>\r
+References: <1400841267-12807-1-git-send-email-felipe.contreras@gmail.com>\r
+       <1400841267-12807-2-git-send-email-felipe.contreras@gmail.com>\r
+       <87wqdai92o.fsf@nikula.org>\r
+       <5381a172d52b5_d72bf52fc50@nysa.notmuch>\r
+       <87r43ii5dx.fsf@nikula.org>\r
+       <5382107e7870f_2275ff3304ec@nysa.notmuch>\r
+User-Agent: Notmuch/0.18~rc0+2~gbc64cdc (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 25 May 2014 20:01:44 +0300\r
+Message-ID: <87k399iyh3.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: Ali Polatel <alip@exherbo.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 25 May 2014 17:01:54 -0000\r
+\r
+On Sun, 25 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+> Jani Nikula wrote:\r
+>> On Sun, 25 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+>> > Jani Nikula wrote:\r
+>> >> On Fri, 23 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+>> >> > They don't affect the global build.\r
+>> >> \r
+>> >> They do.\r
+>> >\r
+>> > They don't.\r
+>> \r
+>> Your patch, your commit message, please explain *why* you think they\r
+>> wouldn't or shouldn't affect the global build. Just to mention one\r
+>> thing, why someone modifying cflags in sub makefiles shouldn't cause\r
+>> rebuild?\r
+>\r
+> Go to emacs/Makefile, it's basically a stub, why would any modifications\r
+> there affect the global build? It's not included anywhere.\r
+>\r
+> emacs/Makefile.local is included in the global build, emacs/Makefile is\r
+> not.\r
+\r
+Fair enough. And what is the benefit of not depending on them, since\r
+they hardly ever change? I'd rather err on the depending side.\r
+\r
+BR,\r
+Jani.\r