Re: [PATCH 1/2] Add part filename and content-id in notmuch show output if available.

diff --git a/5d/d6b074c509d16db543317ddf963f8765a37545 b/5d/d6b074c509d16db543317ddf963f8765a37545
new file mode 100644 (file)
index 0000000..1038d79
--- /dev/null
+++ b/5d/d6b074c509d16db543317ddf963f8765a37545
@@ -0,0 +1,101 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 439E2429E5B\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 20:14:16 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id IfhR43hfHWWU for <notmuch@notmuchmail.org>;\r
+       Tue, 28 Jun 2011 20:14:15 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id C253A429E55\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 20:14:15 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 87B5D29A51E;\r
+       Tue, 28 Jun 2011 20:14:14 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 75BEB2541A8; Tue, 28 Jun 2011 20:14:14 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] Add part filename and content-id in notmuch show\r
+       output if available.\r
+In-Reply-To: <1306620228-24351-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1306620228-24351-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Tue, 28 Jun 2011 20:14:08 -0700\r
+Message-ID: <87iprp72in.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 Jun 2011 03:14:16 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sun, 29 May 2011 02:03:47 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=\r
+l.com> wrote:\r
+> Also, the patch adds Content-id to text output format of notmuch\r
+> show.\r
+\r
+I don't think I've raised this point before, but I've been tempted to\r
+setup a git hook that rejects any commits with a paragraph beginning\r
+with the word "also" or the word "additionally". These words are clues\r
+to me that the commit is doing multiple independent things and should\r
+really be split up.\r
+\r
+> The patch makes notmuch show always output filename if available,\r
+> independent of Content-Disposition.  Both JSON and text output\r
+> formats are changed.\r
+\r
+The commit message claims to change both JSON and text output, (and the\r
+patch bears that out). But the test suite only gets changes to text\r
+output.\r
+\r
+This suggests to me that the test suite needs an additional test here\r
+(for a "Content-Disposition: inline" attachment with a filename).\r
+\r
+What can I say, I must be feeling soft today, because in spite of both\r
+of those issues I've just pushed these two commits, (I did augment the\r
+commit message of the second commit to be more than a single line=E2=80=94I=\r
+ know\r
+that I've discussed that issue before).\r
+\r
+Thanks, Dmitry, for the improvements.\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk4KmIAACgkQ6JDdNq8qSWjm0gCfdxQ/xyL3eA1eMhHDLooglEha\r
+x1IAniiWNWvrNUy1R5nh9G5G6hpP0lWE\r
+=fW5D\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r