Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable
authorJinwoo Lee <jinwoo68@gmail.com>
Sun, 14 Jun 2015 15:16:03 +0000 (08:16 +1700)
committerW. Trevor King <wking@tremily.us>
Sat, 20 Aug 2016 21:49:04 +0000 (14:49 -0700)
3e/c5bb25005c9292feaabc8b07c6fc9ad6ef437c [new file with mode: 0644]

diff --git a/3e/c5bb25005c9292feaabc8b07c6fc9ad6ef437c b/3e/c5bb25005c9292feaabc8b07c6fc9ad6ef437c
new file mode 100644 (file)
index 0000000..3057a74
--- /dev/null
@@ -0,0 +1,112 @@
+Return-Path: <jinwoo68@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id BEB1B6DE1639\r
+ for <notmuch@notmuchmail.org>; Sun, 14 Jun 2015 08:16:17 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.562\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.562 tagged_above=-999 required=5\r
+ tests=[AWL=-0.011, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,\r
+ DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001,\r
+ SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id z4dmp2mEIrFb for <notmuch@notmuchmail.org>;\r
+ Sun, 14 Jun 2015 08:16:15 -0700 (PDT)\r
+Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com\r
+ [209.85.192.182])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 8696C6DE15E3\r
+ for <notmuch@notmuchmail.org>; Sun, 14 Jun 2015 08:16:15 -0700 (PDT)\r
+Received: by pdbki1 with SMTP id ki1so54941121pdb.1\r
+ for <notmuch@notmuchmail.org>; Sun, 14 Jun 2015 08:16:15 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=j8MZd99Gd9ZyvMc3B6vIPpVZpMFTlF6hm6aeHviCgYQ=;\r
+ b=AZRb3x2xlyLMkIqaKHNdKbBffUr5G6Zz6QUMX19H1aC0AQkRB1jnuS5i1ghk8BTNPF\r
+ vrAHPNMGFKfNFgvTHCVeLrMoFgRR4/VLR7aBz71ZcO6YoR6940QV8V0d//L5oJRfN+/f\r
+ jF7nCVka+XDV9r1AIus/CADx/YFEAnyP+Ra5HD9Y1o+rVmJkGfy57NEjk+6Nz24FZNdQ\r
+ uCTdR90l8glNZluTFGmtdXVkFzn+JPqBMeVcz04aJGo2eth10Z2QhYKPlFfq8/m/eJP0\r
+ EewGNUwyNZeWIjynKWtcGiRRBQfAC+Rt86MCTKLhD5+h68am8UXe2TXPSKz14yKsRB5v\r
+ 5jjg==\r
+X-Received: by 10.68.223.34 with SMTP id qr2mr39746394pbc.140.1434294975093;\r
+ Sun, 14 Jun 2015 08:16:15 -0700 (PDT)\r
+Received: from localhost ([2601:647:4b02:71ea:aceb:ce29:cbf6:ded6])\r
+ by mx.google.com with ESMTPSA id gp1sm9441088pbd.64.2015.06.14.08.16.12\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Sun, 14 Jun 2015 08:16:13 -0700 (PDT)\r
+From: Jinwoo Lee <jinwoo68@gmail.com>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable\r
+In-Reply-To: <87r3peye4q.fsf@maritornes.cs.unb.ca>\r
+References: <1433142542-2307-3-git-send-email-david@tethera.net>\r
+ <1434261524-14139-1-git-send-email-david@tethera.net>\r
+ <yq65a8w2u7yv.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+ <87r3peye4q.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.20.1+21~g4e79903 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-apple-darwin14.3.0)\r
+Date: Sun, 14 Jun 2015 08:16:03 -0700\r
+Message-ID: <yq657fr6tj64.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 14 Jun 2015 15:16:17 -0000\r
+\r
+On Sat, Jun 13, 2015 at 11:53 PM, David Bremner <david@tethera.net> wrote:\r
+> Jinwoo Lee <jinwoo68@gmail.com> writes:\r
+>\r
+>> There are 2 problems.\r
+>>\r
+>> 1. The file, bindings/Makefile.local still has lib/libnotmuch.so as the\r
+>>    dependency of ruby-bindings.\r
+>\r
+> this is fixed in\r
+>\r
+>      id:1434263191-14171-1-git-send-email-david@tethera.net\r
+>\r
+> an updated patch sent a few minutes ago.\r
+>\r
+>>\r
+>>> cd bindings/ruby && \\r
+>>>            EXTRA_LDFLAGS="" \\r
+>>>            ruby extconf.rb --vendor\r
+>>> checking for notmuch_database_create in libnotmuch.so... no\r
+>>> *** extconf.rb failed ***\r
+>\r
+> This should also be fixed by the same patch, since that test is\r
+> eliminated.\r
+>\r
+>> ld: warning: ignoring file ../../lib/libnotmuch.dylib, file was built for x86_64 which is not the architecture being linked (i386): ../../lib/libnotmuch.dylib\r
+>\r
+> On the other hand, this suggests there is still something broken with\r
+> building the ruby extensions on mac. I think if noone has a better idea,\r
+> and the updated versions of the two patches I sent to the list this\r
+> morning don't help, I'll just add a "--without-ruby" option to the\r
+> config script. In the long run, we probably want such an option anyway.  \r
+\r
+When I apply those 2 patches from you, things seem to work.  I still get\r
+warnings like below, but they don't seem severe.  I'm not sure if the\r
+ruby binding actually works though.\r
+\r
+ld: warning: directory not found for option '-L/usr/local/lib'\r
+ld: warning: directory not found for option '-L/usr/local/lib'\r
+ld: warning: ignoring file ../../lib/libnotmuch.dylib, file was built for x86_64 which is not the architecture being linked (i386): ../../lib/libnotmuch.dylib\r
+\r
+Thanks, David, for the quick fix!\r
+\r
+-jinwoo\r