Re: [PATCH v4 09/16] index encrypted parts when asked.

diff --git a/b6/2d2f109fc7b60604e150b9853e12ec99287557 b/b6/2d2f109fc7b60604e150b9853e12ec99287557
new file mode 100644 (file)
index 0000000..34c2aef
--- /dev/null
+++ b/b6/2d2f109fc7b60604e150b9853e12ec99287557
@@ -0,0 +1,93 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 60FDE6DE00F5\r
+ for <notmuch@notmuchmail.org>; Thu, 14 Jul 2016 09:22:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id yRgyJLHV0jL3 for <notmuch@notmuchmail.org>;\r
+ Thu, 14 Jul 2016 09:22:05 -0700 (PDT)\r
+Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118])\r
+ by arlo.cworth.org (Postfix) with ESMTP id CC8A36DE00C9\r
+ for <notmuch@notmuchmail.org>; Thu, 14 Jul 2016 09:22:05 -0700 (PDT)\r
+Received: from fifthhorseman.net (pD95765AE.dip0.t-ipconnect.de\r
+ [217.87.101.174])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id 8A17DF98B;\r
+ Thu, 14 Jul 2016 12:22:03 -0400 (EDT)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id 3D9CC20111; Thu, 14 Jul 2016 18:22:02 +0200 (CEST)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v4 09/16] index encrypted parts when asked.\r
+In-Reply-To: <87lh14e2x8.fsf@tesseract.cs.unb.ca>\r
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1467970047-8013-10-git-send-email-dkg@fifthhorseman.net>\r
+ <87lh14e2x8.fsf@tesseract.cs.unb.ca>\r
+User-Agent: Notmuch/0.22+77~gaba8744 (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Thu, 14 Jul 2016 18:22:01 +0200\r
+Message-ID: <8737ncmbpy.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 14 Jul 2016 16:22:14 -0000\r
+\r
+On Thu 2016-07-14 15:59:15 +0200, David Bremner wrote:\r
+> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+>\r
+>> +    status = _notmuch_crypto_get_gmime_ctx_for_protocol (&(indexopts->crypto),\r
+>> +                                                    protocol, &crypto_ctx);\r
+>> +    if (status) {\r
+>> +   _notmuch_database_log (notmuch, "Warning: setup failed for decrypting "\r
+>> +                          "during indexing. (%d)\n", status);\r
+>> +   status = notmuch_message_add_property (message, "index-decryption", "failure");\r
+>> +   if (status)\r
+>> +       _notmuch_database_log (notmuch, "failed to add index-decryption "\r
+>> +                              "property (%d)\n", status);\r
+>> +   return;\r
+>> +    }\r
+>\r
+> Currently the only correct usage of _notmuch_database_log is the\r
+> following pattern\r
+>\r
+>           _notmuch_database_log (notmuch, "Cannot write to a read-only database.\n");\r
+>           return NOTMUCH_STATUS_READ_ONLY_DATABASE;\r
+>\r
+> In particular, the log buffer is only one line, and the caller needs to\r
+> know to retrieve it.\r
+>\r
+> I agree it's not ideal, but I doubt you want to delay your stuff in\r
+> order to extend/fix the internal logging API.\r
+\r
+I understand that the internal log is currently only a single line, but\r
+following the usage pattern you describe isn't useful for this case.\r
+\r
+What is your suggested fix?  a given message could have multiple parts,\r
+some of which are decryptable and others of which are not.\r
+\r
+It makes no sense to stop indexing a message just because one of the\r
+parts failed to decrypt, so i'm not going to immediately return.\r
+\r
+I'm willing to accept that only the last log message will make it out to\r
+the caller, and i could track whether anything has been written to the\r
+log and change the return value in that case.  would that be acceptable?\r
+\r
+    --dkg\r