Re: [PATCH] build: fix out-of-tree builds

diff --git a/40/217e0f4b6ffe0b598d24b9f49b4e6e6241bb34 b/40/217e0f4b6ffe0b598d24b9f49b4e6e6241bb34
new file mode 100644 (file)
index 0000000..9709861
--- /dev/null
+++ b/40/217e0f4b6ffe0b598d24b9f49b4e6e6241bb34
@@ -0,0 +1,92 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 98619431FC3\r
+       for <notmuch@notmuchmail.org>; Thu, 16 May 2013 05:01:19 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id L8Al97T2CiPT for <notmuch@notmuchmail.org>;\r
+       Thu, 16 May 2013 05:01:14 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 68C68431FC2\r
+       for <notmuch@notmuchmail.org>; Thu, 16 May 2013 05:01:14 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id DFB07100094;\r
+       Thu, 16 May 2013 15:01:10 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] build: fix out-of-tree builds\r
+In-Reply-To: <87hai3dvkm.fsf@zancas.localnet>\r
+References: <1368615519-25977-1-git-send-email-jani@nikula.org>\r
+       <87ehd8fdzg.fsf@zancas.localnet> <874ne49pcm.fsf@nikula.org>\r
+       <87hai3dvkm.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 16 May 2013 15:01:10 +0300\r
+Message-ID: <m2sj1n6smx.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 16 May 2013 12:01:19 -0000\r
+\r
+On Thu, May 16 2013, David Bremner <david@tethera.net> wrote:\r
+\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>> On Wed, 15 May 2013, David Bremner <david@tethera.net> wrote:\r
+>>> Jani Nikula <jani@nikula.org> writes:\r
+>>>>  # List all subdirectories here. Each contains its own Makefile.local\r
+>>>> -subdirs := compat completion emacs lib man parse-time-string\r
+>>>> -subdirs += performance-test util test\r
+>>>> +subdirs = compat completion emacs lib man parse-time-string performance-test util test\r
+>>>\r
+>>> Is this a functional change or a cosmetic one?\r
+>>\r
+>> Functional. All of it seems to be required for out-of-tree builds (*) to\r
+>> work. I'm afraid I've forgotten exactly why both := and += make it fail\r
+>> (I wrote the patch a few months ago).\r
+>>\r
+>\r
+> Still I guess it deserves a comment so we don't break it again?\r
+\r
+The following options could be tested (some day in (distant?) future):\r
+\r
+subdirs = compat completion emacs lib man parse-time-string\r
+subdirs += performance-test util test\r
+\r
+or \r
+\r
+SUBDIRS := compat completion emacs lib man parse-time-string\r
+SUBDIRS += performance-test util test\r
+subdirs = $(SUBDIRS)\r
+\r
+but as Jani has already tested his version works just adding that\r
+comment David asked is the least labor-intensive thing to do --\r
+and therefore IMHO the best thing to do for this case\r
+(for sure I'm not going to spend more time on this now :D).\r
+\r
+> d\r
+\r
+Tomi\r