--- /dev/null
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id A814D431FC0\r
+ for <notmuch@notmuchmail.org>; Tue, 20 Aug 2013 08:18:08 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id kZEaRMFaNJQ5 for <notmuch@notmuchmail.org>;\r
+ Tue, 20 Aug 2013 08:18:04 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+ [131.215.239.19])\r
+ by olra.theworths.org (Postfix) with ESMTP id 444B0431FB6\r
+ for <notmuch@notmuchmail.org>; Tue, 20 Aug 2013 08:18:04 -0700 (PDT)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+ by fire-doxen-postvirus (Postfix) with ESMTP id AC1A732802C;\r
+ Tue, 20 Aug 2013 08:18:01 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-76-173-75-27.socal.res.rr.com\r
+ [76.173.75.27]) (Authenticated sender: jrollins)\r
+ by fire-doxen-submit (Postfix) with ESMTP id DADAE2E50D38;\r
+ Tue, 20 Aug 2013 08:17:57 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+ id 627D761730; Tue, 20 Aug 2013 08:17:57 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Istvan Marko <notmuch@kismala.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts\r
+In-Reply-To: <m3r4dtgz9k.fsf@zsu.kismala.com>\r
+References: <m3r4dtgz9k.fsf@zsu.kismala.com>\r
+User-Agent: Notmuch/0.16+1~g9f861e2 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 20 Aug 2013 08:17:54 -0700\r
+Message-ID: <87fvu4fl25.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 20 Aug 2013 15:18:08 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Fri, Aug 16 2013, Istvan Marko <notmuch@kismala.com> wrote:\r
+> When text/html parts include images as multipart/related and the\r
+> text/plain alternative is used these images can be completely hidden\r
+> with no easy way to access them or even find out that they are there.\r
+>\r
+> Make notmuch-show-insert-part-multipart/related add buttons for all\r
+> parts, the first one visible the rest hidden.\r
+\r
+Hey, Istvan. Thanks so much for this patch. It seems to be addressing\r
+the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net.\r
+\r
+However, the behavior of the part button that now appears seems to be a\r
+bit strange. Clicking/hitting enter on the part attempts to save it\r
+rather than open it. I wouldn't be surprised if has nothing to do with\r
+the correctness of this patch, though. So is it possible that the\r
+button is not inserted in the most ideal way, or is there some other\r
+issue preventing it from behaving properly (could it have to do with the\r
+part being "inline"?)?\r
+\r
+jamie.\r
+\r
+\r
+> emacs/notmuch-show.el | 4 ++++\r
+> 1 file changed, 4 insertions(+)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 82b70ba..20844f0 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -621,6 +621,10 @@ message at DEPTH in the current thread."\r
+>=20=20\r
+> ;; Render the primary part.\r
+> (notmuch-show-insert-bodypart msg (car inner-parts) depth)\r
+> + ;; Add hidden buttons for the rest\r
+> + (mapc (lambda (inner-part)\r
+> + (notmuch-show-insert-bodypart msg inner-part depth t))\r
+> + (cdr inner-parts))\r
+>=20=20\r
+> (when notmuch-show-indent-multipart\r
+> (indent-rigidly start (point) 1)))\r
+> --=20\r
+> 1.8.1.4\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.14 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJSE4ijAAoJEO00zqvie6q86CYP/ioM/6FNf947Gni2n2EpSgCs\r
+csO1rxQrEHuLvcTljUDBfwP0R8NC7y22mGCl1iBx6mVcXKjPTQa97WVqBPRSYsJR\r
+FcIycTW0MSBp5rOX8ZvsJG4DxlF8I+NLctne35uwWawE0LQqYz2QHERdr59YB438\r
+qVNdZkcakEPUaK44Upk9FIEo7efEtIjSBkCFIDEMgiTVOz+dqW79SuDRx1oJjeit\r
+0eyKDtLdqXvfUjvI0xD/zcdYU36W2BI175EjmuAnr1Ow50Q73AQFzjaF+z4DtOjr\r
++saXVPiRiuO45LgvW0JAVc11sY8t1+caFjx2zFnRy/8viGyWEvnLmucoTf/yWAvR\r
+L1PnI4Gb9qykGl2SS+npfuTrZdVgicun8S/H8n0lt5HEI03Ku2GzfF38kXB4w3dj\r
+CBsZrCKAKCErSfhGp/ZvT4O6qCaZ08BRzZmXebXTPI5PKPTwEDBL7M9doCPT/ZvV\r
+XspKqS9bKXfERos28sWUWAJxgxo7SCEiYqZgX4mKFpUk5jkOTY5oIWDWs+2C1EZa\r
+HOI5ZQxCm7RjLbfz//o4zA4ukCTerMFRREwFfi8eju34Hdv1tBB0Zyo8k7vpv3Eu\r
+cTmdxmOcmgTWOvNrKUx6cfoLZmFx42z7pHVVHU62GxvLHUIvLEuVDV2MPjlLgRev\r
+5TnpD03LLoaZx4pM3rUB\r
+=MEVP\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff