eclass/go-module: remove go-get for corner case of unneeded deep build dependencies

The helper function used to call 'go get' to verify by fake-fetching everything
from the main go.mod. However 'go get' also turns out to recursively try to
fetch everything in dependencies, even materials that are used only for tests
of the dependencies, or code generation.

If EGO_SUM is missing an entry now, it will fail during the build process
rather than the helper function.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
index 4edffa70e42b17ba18e274f477a5216c4e7c886b..17d37494f15fee5792614f8ef551c0b68e39d566 100644 (file)
--- a/eclass/go-module.eclass
+++ b/eclass/go-module.eclass
@@ -415,17 +415,12 @@ _go-module_src_unpack_verify_gosum() {
        einfo "Tidying go.mod/go.sum"
        go mod tidy >/dev/null
 
-       # Verify that all needed modules are really present, by fetching everything
-       # in the package's main go.mod.  If the EGO_SUM was missing an entry then
-       # 'go mod tidy' && 'go get' will flag it.
-       # -v = verbose
-       # -d = download only, don't install
-       einfo "Verifying linked Golang modules"
-       go get \
-               -v \
-               -d \
-               all \
-               || die "Some module is missing, update EGO_SUM"
+       # This used to call 'go get' to verify by fetching everything from the main
+       # go.mod. However 'go get' also turns out to recursively try to fetch
+       # everything in dependencies, even materials that are used only for tests
+       # of the dependencies, or code generation.
+       # If EGO_SUM is missing an entry now, it will fail during the build process
+       # rather than this helper function.
 }
 
 # @FUNCTION: go-module_live_vendor