Re: [PATCH v3 4/4] emacs: add notmuch-hello-hook

diff --git a/49/10af77dde9d91c8d22632e97a05cac80f2932c b/49/10af77dde9d91c8d22632e97a05cac80f2932c
new file mode 100644 (file)
index 0000000..9796ff2
--- /dev/null
+++ b/49/10af77dde9d91c8d22632e97a05cac80f2932c
@@ -0,0 +1,116 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B425B429E26\r
+       for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 09:49:40 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 24WSUe3CdThO for <notmuch@notmuchmail.org>;\r
+       Tue, 13 Dec 2011 09:49:40 -0800 (PST)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 0B0F2429E25   for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 09:49:39 -0800\r
+ (PST)\r
+Received: by wgbds13 with SMTP id ds13so11326375wgb.2\r
+       for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 09:49:37 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=RcFPd1yQ+M3fnBK0uvdSUvCqOxzHUKYGszLOKxyeX/I=;\r
+       b=BAOBCmCkfMKWPts4ttff2tuXJuaal+8rSqWWNkjNuwnTonVGxSs71MAXdjkw1QqAJ8\r
+       9U7Z3QBO6d6zG2MJGleYcHLjUbaOcDCm4SGdXgenNaK/01IeXJoLVSNKPbe8mMLpmhPc\r
+       Tz0YnRhW+sP9ldl8AhAAsLJYOGmOzAyK+lAmE=\r
+Received: by 10.227.199.78 with SMTP id er14mr17305616wbb.10.1323798577432;\r
+       Tue, 13 Dec 2011 09:49:37 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id em4sm27495171wbb.20.2011.12.13.09.49.36\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Tue, 13 Dec 2011 09:49:36 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 4/4] emacs: add notmuch-hello-hook\r
+In-Reply-To: <1323797532-597-5-git-send-email-schnouki@schnouki.net>\r
+References: <87d3cx2t38.fsf@rocinante.cs.unb.ca>\r
+       <1323797532-597-1-git-send-email-schnouki@schnouki.net>\r
+       <1323797532-597-5-git-send-email-schnouki@schnouki.net>\r
+User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 13 Dec 2011 21:49:00 +0400\r
+Message-ID: <87zkewuzub.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 13 Dec 2011 17:49:40 -0000\r
+\r
+On Tue, 13 Dec 2011 18:32:12 +0100, Thomas Jost <schnouki@schnouki.net> wrote:\r
+> This hook is called every time the notmuch-hello buffer is updated.\r
+> ---\r
+>  emacs/notmuch-hello.el |    9 ++++++++-\r
+>  1 files changed, 8 insertions(+), 1 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> index 0fe9c1d..112b40b 100644\r
+> --- a/emacs/notmuch-hello.el\r
+> +++ b/emacs/notmuch-hello.el\r
+> @@ -131,6 +131,11 @@ So:\r
+>        (integer :tag "Number of characters")\r
+>        (float :tag "Fraction of window")))\r
+>  \r
+> +(defcustom notmuch-hello-hook nil\r
+> +  "Functions called after populating a `notmuch-hello' buffer."\r
+> +  :type 'hook\r
+> +  :group 'notmuch)\r
+> +\r
+>  (defcustom notmuch-thousands-separator ","\r
+>    "The string used as a thousands separator.\r
+>  \r
+> @@ -579,7 +584,9 @@ Complete list of currently available key bindings:\r
+>        (widget-forward 1)))\r
+>  \r
+>        (unless (widget-at)\r
+> -    (notmuch-hello-goto-search)))))\r
+> +    (notmuch-hello-goto-search))\r
+> +\r
+> +      (run-hooks 'notmuch-hello-hook))))\r
+>  \r
+\r
+I spent some time finding out why run-hooks are not on the top level.\r
+Turns out it is inside two let statements.  Can we move to the top level\r
+of `notmuch-hello' to make it clear that it is always run (i.e. there\r
+are no ifs or whens)?\r
+\r
+BTW this would replace one of the oldest custom patches which I have in\r
+my master branch :)\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+>  (defun notmuch-folder ()\r
+>    "Deprecated function for invoking notmuch---calling `notmuch' is preferred now."\r
+> -- \r
+> 1.7.8\r
+> \r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r