Re: [notmuch] [PATCH] notmuch: Add Maildir directory name as tag name for messages

diff --git a/6b/9fa94a8f045ec19f63d721955b9a9035800c9e b/6b/9fa94a8f045ec19f63d721955b9a9035800c9e
new file mode 100644 (file)
index 0000000..fc3c051
--- /dev/null
+++ b/6b/9fa94a8f045ec19f63d721955b9a9035800c9e
@@ -0,0 +1,99 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8FF86431FC0;\r
+       Fri, 27 Nov 2009 19:27:12 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id O0BivdOFRl26; Fri, 27 Nov 2009 19:27:11 -0800 (PST)\r
+Received: from cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 68A73431FAE;\r
+       Fri, 27 Nov 2009 19:27:11 -0800 (PST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Michiel Buddingh' <michiel@michielbuddingh.net>, notmuch@notmuchmail.org\r
+In-Reply-To: <4b0eef22.JwxdgTGElffx149F%michiel@michielbuddingh.net>\r
+References: <87fx8bygi7.fsf@linux.vnet.ibm.com>\r
+       <87bpiv4t9h.fsf@yoom.home.cworth.org>\r
+       <87y6lz39nd.fsf@yoom.home.cworth.org>\r
+       <20091121221207.GB17268@jukie.net>\r
+       <9cce5525b093b87fe74d427954ffad89@localhost>\r
+       <87d43b2oif.fsf@yoom.home.cworth.org>\r
+       <9bfdedddeab9c58cd45d8d448323d0fc@localhost>\r
+       <87skc23327.fsf@yoom.home.cworth.org>\r
+       <4b0eef22.JwxdgTGElffx149F%michiel@michielbuddingh.net>\r
+Date: Fri, 27 Nov 2009 19:26:57 -0800\r
+Message-ID: <87ws1bjpmm.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Subject: Re: [notmuch] [PATCH] notmuch: Add Maildir directory name as tag\r
+ name for messages\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 28 Nov 2009 03:27:12 -0000\r
+\r
+On Thu, 26 Nov 2009 22:12:02 +0100, Michiel Buddingh' <michiel@michielbuddingh.net> wrote:\r
+> Carl Worth <cworth@cworth.org> wrote:\r
+>   I considered that approach; ideally, we could test for the presence of\r
+> all three of cur, tmp and new--but this is rather messy to do in the\r
+> current treewalk structure.  Taking any one of them as proof positive of\r
+> a Maildir might lead to unpleasant surprises--it's not all that incon-\r
+> ceivable for someone to name a mail folder 'tmp'.\r
+\r
+The auto-detection is just three additional stats (at most) for each\r
+directory, right? That seems cheap enough to me.\r
+\r
+>   There's another matter; Some mail stores will place (large) index files\r
+> in folder roots, i.e. one level above cur/, tmp/ and new/.  Looking\r
+> at the ones dovecot (an IMAP server) uses, I can make out a from header,\r
+> a subject header, and a message-id, as plaintext in the first 100k or\r
+> so.  It's not all that inconceivable that notmuch might register it as\r
+> a 'real' email, with unpleasant consequences for the index.\r
+\r
+That seems orthogonal to me. Would the dovecot index files be easy to\r
+skip with a pattern-based blacklist?\r
+\r
+>   I've seen some patches fly by that add support for multiple mail\r
+> stores.  Turning on Maildir support on a per-directory basis might\r
+> resolve that problem while still supporting heterogenous mail archives\r
+> to some degree.  I am not convinced we can do the right thing\r
+> automatically without causing some grief to a subset of users.\r
+\r
+With sup, I had the opposite extreme compared to current notmuch. Every\r
+maildir in the hierarchy had to be configured independently. That was a\r
+lot of pain, and is precisely why notmuch started out by simply taking a\r
+single top-level directory.\r
+\r
+> Haven't tested it, but it seems you can put\r
+> \r
+> [core]\r
+>     whitespace = trailing-space,space-before-tab\r
+\r
+Yes. According to the documentation of git-config, those two values are\r
+the default. But the documentation also only says that these will make\r
+"git diff" display the undesired whitespace in red, and "git apply\r
+--whitespace=error" refuse to apply.\r
+\r
+I can't find a builtin way to make "git commit" complain, or I would\r
+recommend that.\r
+\r
+> I'll be happy to implement them, although I'd like for others to chime\r
+> in on the configure-as-Maildir vs. autodetect-Maildir issue.  And thanks\r
+> for your patience in working through my patch.\r
+\r
+No problem at all. I'll look forward to the next version of the\r
+patch. Consider mine as a vote for autodetection of maildir rather than\r
+configuration.\r
+\r
+-Carl\r