misc-functions.sh: move sleep out of loop

Having sleep in the world-writable loop causes riduculous delays for
prefix users with exotic filesystem constraints (like a FAT filesystem
mounted with umask=000).

diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh
index b3e62c5fe3941b4da696a67a4d3a712dde4164c1..0d2d20689a3e7bfd57b3a1723a8f20c2bb679442 100755 (executable)
--- a/bin/misc-functions.sh
+++ b/bin/misc-functions.sh
@@ -166,14 +166,14 @@ install_qa_check() {
        fi
 
        # Now we look for all world writable files.
-       local i
+       local i=
        for i in $(find "${D}/" -type f -perm -2); do
                vecho "QA Security Notice:"
                vecho "- ${i:${#D}:${#i}} will be a world writable file."
                vecho "- This may or may not be a security problem, most of the time it is one."
                vecho "- Please double check that $PF really needs a world writeable bit and file bugs accordingly."
-               sleep 1
        done
+       [[ -n ${i} ]] && sleep 1
 
        if type -P scanelf > /dev/null && ! has binchecks ${RESTRICT}; then
                local qa_var insecure_rpath=0 tmp_quiet=${PORTAGE_QUIET}