Re: [PATCH 0/3] Introduce the add command

diff --git a/6e/fa5e4e26d15026aa3bd14a04b83c779c5d383a b/6e/fa5e4e26d15026aa3bd14a04b83c779c5d383a
new file mode 100644 (file)
index 0000000..e2e3bf7
--- /dev/null
+++ b/6e/fa5e4e26d15026aa3bd14a04b83c779c5d383a
@@ -0,0 +1,107 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7A2BE431FBD\r
+       for <notmuch@notmuchmail.org>; Fri, 19 Jul 2013 07:48:21 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id S0qERT7WHkFZ for <notmuch@notmuchmail.org>;\r
+       Fri, 19 Jul 2013 07:48:16 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id DC365431FC2\r
+       for <notmuch@notmuchmail.org>; Fri, 19 Jul 2013 07:48:15 -0700 (PDT)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 56C2F328040;\r
+       Fri, 19 Jul 2013 07:48:15 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (lair.fifthhorseman.net [108.58.6.98])\r
+       (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id 7AAC232806D;\r
+       Fri, 19 Jul 2013 07:48:12 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 8F29762962; Fri, 19 Jul 2013 07:48:09 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/3] Introduce the add command\r
+In-Reply-To: <1373762746-22308-1-git-send-email-awg+notmuch@xvx.ca>\r
+References: <1373762746-22308-1-git-send-email-awg+notmuch@xvx.ca>\r
+User-Agent: Notmuch/0.15.2+223~g9020f68 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 19 Jul 2013 07:48:06 -0700\r
+Message-ID: <87wqom8v2x.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 19 Jul 2013 14:48:21 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+On Sat, Jul 13 2013, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:\r
+> The recent introduction of insert inspired me to finally add a feature I've\r
+> been wanting: a command to index a specific file in the maildir. My usecase\r
+> for this is that I have an inotify-based script that watches for new mail\r
+> and calls notmuch new when new mail shows up. Running notmuch new in this\r
+> situation is overkill, since I know exactly what's changed. A faster command\r
+> that just adds a single file reduces contention on the database lock.\r
+>\r
+> This series introduces a new command, "notmuch add", which indexes a file\r
+> that already exists in the maildir. It is implemented in notmuch-insert.c\r
+> because it uses the basic infrastructure introduced for the insert command.\r
+>\r
+> Missing man page for now - wanted to get the code out first for review.\r
+\r
+Hey, Adam.  This feature seems fine, but it seems similar enought to\r
+insert that I wonder if they can just be unified.  What if insert just\r
+took an optional path argument as well, e.g.:\r
+\r
+  notmuch insert [options] [ +<tag>|-<tag> ... ] [-- /path/to/file]\r
+\r
+If the path is not in the db, it would insert it the same as if it had\r
+come in via stdin.  If the path *is* in the db, it could just do the add\r
+part that you're looking for.  That seems like it might be a more\r
+intuitive UI experience to me.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJR6VGnAAoJEO00zqvie6q83kYP/jGNGIC3wM4O9d5mutvp3abl\r
+arGzPewrLlVN9LWq31xQRusUasKf6GDCn7vfddiMYd7eZfgMAA+Sn9xbQ662gdHn\r
+0wdQW+Vs1x2WntAxaQ+ZfWxE3d5OKn2Hb/4GjXjZaUg9XppA9V0984fsIhdPaWDb\r
+6PbRXtJoC8VLt+yUxvcjywy2CUWLo/xU7FOtV4kZEGxm+zv9kSDj+RliH//jFJ5C\r
+x/HelLow9lO7of8fwU9JwaUsb4zDpy8b1R6iq0Lz4y2PRNb/9LR1S9dHo6h/42Po\r
+xivQF+cENpHmdDBrKy/t3017pWb3Df4ZfD03QbnOUSe+jyqncp1AN/FmKZqFaAj2\r
+g4haRVfrtMf6iAlKeqGAxD5lhwDW2Zd32jhLOw6o3+VgL6Iy0lb431T3A8G49026\r
+W1r1bSkGjFY36gfiH/5YV7XsY7Arj3F0DUQfDPRLMufFJ7wVhsc8B5vpKMu9Jhea\r
+g/lLQ7l/AgzzGX4tsftgJwTJhK/cxzBZZxX6B8s3eW2mCd4YGJGPrngez2uxGy1a\r
+9VZog56pvkJPfblDbKV9CuQqsDeptGPB0rr5ReyW0CQPf0161oUIoThwO1k7ztQd\r
+luYChXia6Au5d8GePGmLPtbD+RSJ5aYycJTb5Fhn1GnPSOl8k9Gq+Q45glmZgdwD\r
+Qg3VrV1bEyJO+BUNUoGT\r
+=ifDO\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r