--- /dev/null
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 60A28431FC0\r
+ for <notmuch@notmuchmail.org>; Tue, 20 May 2014 04:22:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id HrKPNm774EmW for <notmuch@notmuchmail.org>;\r
+ Tue, 20 May 2014 04:22:01 -0700 (PDT)\r
+Received: from mail-we0-f172.google.com (mail-we0-f172.google.com\r
+ [74.125.82.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id F2417431FBC\r
+ for <notmuch@notmuchmail.org>; Tue, 20 May 2014 04:22:00 -0700 (PDT)\r
+Received: by mail-we0-f172.google.com with SMTP id k48so354251wev.3\r
+ for <notmuch@notmuchmail.org>; Tue, 20 May 2014 04:21:58 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:to:subject:in-reply-to:references:user-agent\r
+ :from:date:message-id:mime-version:content-type;\r
+ bh=i0FMV2f+LNfXUALeZAVfhA/t/dSBQudtOYiu2o3TFqU=;\r
+ b=KSoDpRKUq9oCDWAJ7yK08WDfi1+18kQwoozsUHnGGydHM8QTxImlJ62bWLJ/CUwReQ\r
+ nVsdT0cujRS1RP0dGs9oESbvpjwkDU8XrHESmgC7JPGHyOUa+Lb9W8SVQjmuaqGy29kE\r
+ CeKDlt3lMM7Uoy6Ee7F3HzTiyf//EVT7ILnsrcPQgLZQn87JtG31y+iZsGhD9BP7TFjg\r
+ It6Ld3ybUkJT/qWKsmXYfgMwW1axkwoXTgi/YTsbBPhWPnmwFA1WJjIr1RE92SigF9L9\r
+ mlUF9Num/QKhQSfkRdvOybxHNTHvdaKkZ6B/A+z7fmbtUTF6ZXJaQL8Sg3X3qDTwZiBN\r
+ 4T3Q==\r
+X-Gm-Message-State:\r
+ ALoCoQmGHYN8bOP107MfbtXHscRkhBPZv4a/QG+xa6aWgpNsjvu5MFix4KHGFxHqoRLd3xSSNSoS\r
+X-Received: by 10.180.228.7 with SMTP id se7mr3510402wic.2.1400584917435;\r
+ Tue, 20 May 2014 04:21:57 -0700 (PDT)\r
+Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8])\r
+ by mx.google.com with ESMTPSA id\r
+ ph8sm17971114wjb.32.2014.05.20.04.21.55 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Tue, 20 May 2014 04:21:56 -0700 (PDT)\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v1] emacs: `notmuch-search-find-stable-query-region'\r
+ should never return an empty query.\r
+In-Reply-To: <87lhtxzb4m.fsf@qmul.ac.uk>\r
+References: <1400515756-31779-1-git-send-email-dme@dme.org>\r
+ <87lhtxzb4m.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-pc-linux-gnu)\r
+From: David Edmondson <dme@dme.org>\r
+Date: Tue, 20 May 2014 12:21:49 +0100\r
+Message-ID: <cunfvk43dbm.fsf@hotblack-desiato.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 20 May 2014 11:22:07 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Mon, May 19 2014, Mark Walters wrote:\r
+> On Mon, 19 May 2014, David Edmondson <dme@dme.org> wrote:\r
+>> `notmuch-search-find-stable-query-region' is expected to examine the\r
+>> region between `beg' and `end' to generate a query that can be used to\r
+>> include all threads in that region. If the region contains no threads,\r
+>> it should throw an error rather than generating an empty query.\r
+>\r
+> Hi\r
+>\r
+> This seems a very definite bug (when testing I managed to archive a\r
+> whole chunk of random messages!)=20\r
+\r
+Do you understand why? I couldn't see a path from this problem to that\r
+failure mode.\r
+\r
+> However, I think I would prefer not to signal an error and just do\r
+> nothing. How about making notmuch-tag check for a nil query (and do\r
+> nothing it's nil). Then rather than an error n.s.f.s.q.r can just return\r
+> nil (this still needs to be special cased as otherwise we get "()" as\r
+> the query.\r
+\r
+Looking around for similar issues (like\r
+`notmuch-show-get-message-properties'), it seems that we would have to\r
+add checks in a lot of places for functions such as this returning `nil'\r
+when they cannot find some state or context.\r
+\r
+Throwing an error makes it clear to the user that nothing is going to\r
+happen - it's not just silent failure.\r
+\r
+(If it's not clear - that was all "I like that it calls `error' :-).\r
+\r
+> Doing this would also fix a bug I found (when seeing what we did\r
+> elsewhere based on the above) in notmuch-tree: trying to change tags at\r
+> the end of the buffer gives an error).\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+>\r
+>> ---\r
+>>\r
+>> Whilst logging calls to 'notmuch' from the UI, I noticed that it would g=\r
+enerate\r
+>> notmuch tag -inbox -- ()\r
+>> if I hit 'a' at the very end of a search buffer. That seems at least\r
+>> useless and possibly bad, so flag an error in this case instead.\r
+>>\r
+>> Oh, the first bit is just cleanup.\r
+>>\r
+>> emacs/notmuch.el | 5 ++++-\r
+>> 1 file changed, 4 insertions(+), 1 deletion(-)\r
+>>\r
+>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+>> index 8aa0104..74103a6 100644\r
+>> --- a/emacs/notmuch.el\r
+>> +++ b/emacs/notmuch.el\r
+>> @@ -429,12 +429,15 @@ matched and unmatched messages in the current thre=\r
+ad."\r
+>>=20=20\r
+>> If ONLY-MATCHED is non-nil, include only matched messages. If it\r
+>> is nil, include both matched and unmatched messages."\r
+>> - (let ((query-list nil) (all (not only-matched)))\r
+>> + (let ((all (not only-matched))\r
+>> + query-list)\r
+>> (dolist (queries (notmuch-search-properties-in-region :query beg en=\r
+d))\r
+>> (when (first queries)\r
+>> (push (first queries) query-list))\r
+>> (when (and all (second queries))\r
+>> (push (second queries) query-list)))\r
+>> + (unless query-list\r
+>> + (error "No threads in region."))\r
+>> (concat "(" (mapconcat 'identity query-list ") or (") ")")))\r
+>>=20=20\r
+>> (defun notmuch-search-find-authors ()\r
+>> --=20\r
+>> 2.0.0.rc0\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1\r
+\r
+iKYEARECAGYFAlN7Os1fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl\r
+bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5\r
+RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRbdUwCfRxbYZfm+srB8U1LadEZw+Oui\r
+3tgAn2MKz81KbhE9yyfUmJcbv/fG5tDv\r
+=UI6X\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff