--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 163F9431FB6\r
+ for <notmuch@notmuchmail.org>; Mon, 10 Jun 2013 08:59:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id o8sPFYXvIx4Y for <notmuch@notmuchmail.org>;\r
+ Mon, 10 Jun 2013 08:59:48 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu\r
+ [18.9.25.15])\r
+ by olra.theworths.org (Postfix) with ESMTP id 98522431FAE\r
+ for <notmuch@notmuchmail.org>; Mon, 10 Jun 2013 08:59:48 -0700 (PDT)\r
+X-AuditID: 1209190f-b7f836d000000ca7-c3-51b5f7f43ffd\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+ by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 54.DD.03239.4F7F5B15; Mon, 10 Jun 2013 11:59:48 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r5AFxjQm003124; \r
+ Mon, 10 Jun 2013 11:59:46 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5AFxgQm008970\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Mon, 10 Jun 2013 11:59:44 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1Um4VR-0001qf-IQ; Mon, 10 Jun 2013 11:59:41 -0400\r
+Date: Mon, 10 Jun 2013 11:59:40 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 1/1] test/basic: replaced find -perm +111 with portable\r
+ alternative\r
+Message-ID: <20130610155940.GE22196@mit.edu>\r
+References: <1370641049-17390-1-git-send-email-tomi.ollila@iki.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1370641049-17390-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT1/3yfWugQecqXovrN2cyW7xZOY/V\r
+ gcnj8NeFLB7PVt1iDmCK4rJJSc3JLEst0rdL4MrYeWo9c8FrnoqfU+YxNzD2cXUxcnJICJhI\r
+ HPrTwQZhi0lcuLcezBYS2Mcocb4xuouRC8jeyChx+8pWVgjnNJPE5jldUM4SRon5Hx8wg7Sw\r
+ CKhKbPp+HcxmE9CQ2LZ/OSOILSKgIvGgbT0riM0sIC3x7XczE4gtLBAp0TDhAQuIzSugI/Hu\r
+ 0ylmiNVOEp+uNbNDxAUlTs58wgLRqyVx499LoF4OsDnL/3GAhDkFnCWOfX4NdrUo0KopJ7ex\r
+ TWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmujlZpbopaaUbmIEhTWn\r
+ JP8Oxm8HlQ4xCnAwKvHwdvzYEijEmlhWXJl7iFGSg0lJlHfOy62BQnxJ+SmVGYnFGfFFpTmp\r
+ xYcYJTiYlUR4k98A5XhTEiurUovyYVLSHCxK4rxXU276CwmkJ5akZqemFqQWwWRlODiUJHh9\r
+ gfErJFiUmp5akZaZU4KQZuLgBBnOAzScE6SGt7ggMbc4Mx0if4pRUUqc1xokIQCSyCjNg+uF\r
+ pZ1XjOJArwjzSoFU8QBTFlz3K6DBTECDp6hvARlckoiQkmpgVFe7ViAnMvdIapBMU7+tcaOB\r
+ f6uZ4AJxVf3gJ9NkTPIrnltdCHc67qPT7yykalt/curzg0IX1waLy2zwreeTudm5/ftq1d0m\r
+ 7CanHoSeNlOcFV7vx/J3b0Rl47sgmxDztf6sGbO+hy5lC+bZ/vMEQ8Rm6b7vVrvb57QGvtX/\r
+ WSjqKOyZJKTEUpyRaKjFXFScCAAd8EuCFgMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 10 Jun 2013 15:59:56 -0000\r
+\r
+LGTM. Though, I wonder, why not *just* -perm -100? That isn't quite\r
+a correct test of whether the user can execute it: e.g., if the file\r
+is owned by some other user and a group the current user isn't in,\r
+then -perm -1 is the correct test, though unless the file has some\r
+unusual permissions, -perm -100 is likely to pass anyway. But the\r
+test you have (and the test that was there before) isn't quite correct\r
+either: if the file is owned by the current user and has some crazy\r
+permission like 0611, the user won't be able to execute it, even\r
+though someone else could.\r
+\r
+It's too bad "-executable" is a GNU extension.\r
+\r
+Quoth Tomi Ollila on Jun 08 at 12:37 am:\r
+> The find option syntax `-perm +111` is deprecated gnu find feature.\r
+> The replacement `( -perm -100 -o -perm -10 -o -perm 1 )` should also\r
+> work outside of the GNU domain.\r
+> ---\r
+> test/basic | 3 ++-\r
+> 1 file changed, 2 insertions(+), 1 deletion(-)\r
+> \r
+> diff --git a/test/basic b/test/basic\r
+> index 1b2a7d2..64eb7d7 100755\r
+> --- a/test/basic\r
+> +++ b/test/basic\r
+> @@ -53,7 +53,8 @@ test_expect_code 2 'failure to clean up causes the test to fail' '\r
+> test_begin_subtest 'Ensure that all available tests will be run by notmuch-test'\r
+> eval $(sed -n -e '/^TESTS="$/,/^"$/p' $TEST_DIRECTORY/notmuch-test)\r
+> tests_in_suite=$(for i in $TESTS; do echo $i; done | sort)\r
+> -available=$(find "$TEST_DIRECTORY" -maxdepth 1 -type f -perm +111 \\r
+> +available=$(find "$TEST_DIRECTORY" -maxdepth 1 -type f \\r
+> + '(' -perm -100 -o -perm -10 -o -perm -1 ')' \\r
+> ! -name aggregate-results.sh \\r
+> ! -name arg-test \\r
+> ! -name hex-xcode \\r
projects / notmuch-archives.git / commitdiff