Re: [PATCH] lib: Simplify close and codify aborting atomic section

diff --git a/62/3893aa0521bf6116b45366c43ef344869bf778 b/62/3893aa0521bf6116b45366c43ef344869bf778
new file mode 100644 (file)
index 0000000..5a0a139
--- /dev/null
+++ b/62/3893aa0521bf6116b45366c43ef344869bf778
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 182F6431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 12:25:34 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 3snuF4Ickw80 for <notmuch@notmuchmail.org>;\r
+       Wed, 24 Sep 2014 12:25:30 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A8087431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 12:25:30 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XWsBq-0001md-O9; Wed, 24 Sep 2014 16:25:26 -0300\r
+Received: (nullmailer pid 22782 invoked by uid 1000); Wed, 24 Sep 2014\r
+       19:25:20 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section\r
+In-Reply-To: <20140924181844.GB20130@odin.tremily.us>\r
+References: <1411400615-20934-1-git-send-email-amdragon@mit.edu>\r
+       <20140922165954.GI20827@odin.tremily.us>\r
+       <20140922185050.GB7970@csail.mit.edu>\r
+       <20140922190022.GO20827@odin.tremily.us>\r
+       <87iokc28mg.fsf@maritornes.cs.unb.ca>\r
+       <20140924181844.GB20130@odin.tremily.us>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 24 Sep 2014 21:25:20 +0200\r
+Message-ID: <87d2ak253z.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 24 Sep 2014 19:25:34 -0000\r
+\r
+"W. Trevor King" <wking@tremily.us> writes:\r
+\r
+>\r
+> Sorry, I didn't phrase that very well.  The notmuch docs (as of this\r
+> patch) explain that we don't commit if we're in an atomic block.  The\r
+> Xapian docs also say that, *and* they say that if we're not in atomic\r
+> block the close *does* try to commit.  I think that's worth mentioning\r
+> in our close docs.\r
+\r
+OK, I see what you mean. I think the fact that you have to close the\r
+notmuch database (when not using begin/end atomic) to get a commit is\r
+surprising for many people, so it would be nice to make that clearer\r
+somehow.\r
+\r
+d\r