Re: Bug: notmuch new chokes on dangling symlinks and quits

diff --git a/99/68a2ccf99728ece251cca0345a993a6f837329 b/99/68a2ccf99728ece251cca0345a993a6f837329
new file mode 100644 (file)
index 0000000..f59aec3
--- /dev/null
+++ b/99/68a2ccf99728ece251cca0345a993a6f837329
@@ -0,0 +1,85 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1045D431FBD\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 09:40:27 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 1TEPkg0bqOJC for <notmuch@notmuchmail.org>;\r
+       Mon, 27 Jan 2014 09:40:19 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 57851431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 09:40:19 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1W7qAU-0006qi-21; Mon, 27 Jan 2014 13:40:18 -0400\r
+Received: (nullmailer pid 6171 invoked by uid 1000); Mon, 27 Jan 2014\r
+       17:40:14 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Gregor Zattler <telegraph@gmx.net>, notmuch <notmuch@notmuchmail.org>\r
+Subject: Re: Bug: notmuch new chokes on dangling symlinks and quits\r
+In-Reply-To: <20140127011427.GD10844@boo.workgroup>\r
+References: <20140126131846.GA10844@boo.workgroup>\r
+       <878uu2n17j.fsf@zancas.localnet> <20140127011427.GD10844@boo.workgroup>\r
+User-Agent: Notmuch/0.17+53~g3e1d7f6 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 27 Jan 2014 13:40:14 -0400\r
+Message-ID: <878uu1l3wh.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 27 Jan 2014 17:40:27 -0000\r
+\r
+Gregor Zattler <telegraph@gmx.net> writes:\r
+\r
+> Hi David,\r
+> * David Bremner <david@tethera.net> [26. Jan. 2014]:\r
+>> Gregor Zattler <telegraph@gmx.net> writes:\r
+>>> I consider this to be a bug.  Instead notmuch should simply\r
+>>> ignore the symlink.\r
+>>>\r
+>> \r
+>> Since there is a test for specifically this behaviour, I'd have to say\r
+>> it's a design decision you don't agree with, not a bug ;).\r
+>\r
+> May I ask why this is so?\r
+>\r
+\r
+Purely from memory (I wasn't involved, and didn't dig up the the\r
+discussion):\r
+\r
+- a common use case is linking different trees into one notmuch-index\r
+  tree.\r
+\r
+- if a subtree disappears (e.g. by a network failure), then the choices\r
+  are stop the index or ignore the missing files.\r
+\r
+- in the latter case, all tags from "deleted" messages are lost\r
+\r
+So, a simple solution which avoids data loss is to abort the index\r
+process.\r
+\r
+A more complicated solution would be possible of course, but nobody\r
+proposed it (or more importantly, did it) yet.\r
+\r
+d\r