Re: [PATCH 00/11] Improve charset and cid: handling

diff --git a/1e/96940313d38c2cdb759e5cd2e501d14047bf15 b/1e/96940313d38c2cdb759e5cd2e501d14047bf15
new file mode 100644 (file)
index 0000000..a3146e0
--- /dev/null
+++ b/1e/96940313d38c2cdb759e5cd2e501d14047bf15
@@ -0,0 +1,107 @@
+Return-Path: <aclements@csail.mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6D8B4431FCB\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 09:29:52 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.138\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.138 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fAZfQNgz2nyh for <notmuch@notmuchmail.org>;\r
+       Sat, 24 Jan 2015 09:29:49 -0800 (PST)\r
+Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])\r
+       by olra.theworths.org (Postfix) with ESMTP id 34AA0431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 09:29:49 -0800 (PST)\r
+Received: from [104.131.20.129] (helo=awakeningjr)\r
+       by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)\r
+       (Exim 4.72) (envelope-from <aclements@csail.mit.edu>)\r
+       id 1YF4Wq-0004cb-Rq; Sat, 24 Jan 2015 12:29:48 -0500\r
+Received: from amthrax by awakeningjr with local (Exim 4.84)\r
+       (envelope-from <aclements@csail.mit.edu>)\r
+       id 1YF4Wq-0003bf-Ij; Sat, 24 Jan 2015 12:29:48 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] Improve charset and cid: handling\r
+In-Reply-To: <87tx9gl5yn.fsf@qmul.ac.uk>\r
+References: <1398105468-14317-1-git-send-email-amdragon@mit.edu>\r
+       <87tx9gl5yn.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 24 Jan 2015 12:29:48 -0500\r
+Message-ID: <87y4ost7cj.fsf@csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 24 Jan 2015 17:29:52 -0000\r
+\r
+I added declare-functions for both of these, which should take care of\r
+the Emacs 23 warnings and be more robust on Emacs 24.  We can't reach\r
+the function that calls these unless shr is actually available, but the\r
+byte compiler doesn't know that.\r
+\r
+On Sat, 26 Apr 2014, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> Aside from the minor comments I mentioned in previous emails and one\r
+> more comment below this looks good. \r
+>\r
+> The extra comment is that on emacs23 I get the following when compiling:\r
+>\r
+> In end of data:\r
+> notmuch-show.el:2188:1:Warning: the following functions are not known to be\r
+>     defined: libxml-parse-html-region, shr-insert-document\r
+>\r
+> Finally, I have not really tested it as I mainly use emacs23\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+>\r
+>\r
+> On Mon, 21 Apr 2014, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>> I set out to quickly add support for cid: links in the shr renderer\r
+>> and wound up making our charset handling more robust and rewriting our\r
+>> content-ID handling.  The test introduced in patch 2 passes in all but\r
+>> one really obscure case, but only because of many unwritten and\r
+>> potentially fragile assumptions that Emacs and the CLI make about each\r
+>> other.\r
+>>\r
+>> The first three patches could reasonably go in to 0.18.  The rest of\r
+>> this series is certainly post-0.18, but I didn't want to lose track of\r
+>> it.\r
+>>\r
+>> This series comes in three stages.  Each depends on the earlier ones,\r
+>> but each prefix makes sense on its own and could be pushed without the\r
+>> later stages.\r
+>>\r
+>> Patch 1 is a simple clean up patch.\r
+>>\r
+>> Patches 2 through 7 robust-ify our charset handling in Emacs, mostly\r
+>> by splitting the broken `notmuch-get-bodypart-content' API into\r
+>> `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text' so a\r
+>> caller can explicitly convey their requirements.\r
+>>\r
+>> The remaining patches improve our content-ID handling and add support\r
+>> for cid: links for shr.\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r