Re: [PATCH] emacs: Avoid deprecated function flet

diff --git a/8a/be1097d08e6f9bdae1c49c86ccebfb27f2e073 b/8a/be1097d08e6f9bdae1c49c86ccebfb27f2e073
new file mode 100644 (file)
index 0000000..9bba99f
--- /dev/null
+++ b/8a/be1097d08e6f9bdae1c49c86ccebfb27f2e073
@@ -0,0 +1,83 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C742F431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 20 May 2013 08:45:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id FZiuxsSOfsIN for <notmuch@notmuchmail.org>;\r
+       Mon, 20 May 2013 08:45:49 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 257FB431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 20 May 2013 08:45:49 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4KFjl4H008228;\r
+       Mon, 20 May 2013 12:45:47 -0300\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UeSHT-0007T2-CW; Mon, 20 May 2013 12:45:47 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UeSHN-0007hv-HX; Mon, 20 May 2013 12:45:41 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Avoid deprecated function flet\r
+In-Reply-To: <1368976447-5153-1-git-send-email-amdragon@mit.edu>\r
+References: <87vc6fjjdp.fsf@zancas.localnet>\r
+       <1368976447-5153-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+105~ge63aa66 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 20 May 2013 12:45:41 -0300\r
+Message-ID: <8761ydr6xm.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 20 May 2013 15:45:57 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> flet was deprecated in Emacs 24.3 and replaced with cl-flet.  However,\r
+> cl-flet lexically binds the function symbol, while we depend on flet\r
+> dynamically binding the function symbol.  Hence, this patch replaces\r
+> the deprecated flet use with letf, which lets us dynamically bind the\r
+> function symbol, while remaining compatible with both Emacs 23 and 24.\r
+\r
+The bad news: letf is also marked as obsolete, although there is no\r
+yelling from the byte-compiler yet.\r
+\r
+In my simple tests, it _seemed_ to work to replace letf with cl-letf,\r
+although\r
+\r
+- that would require some kind of compatability alias\r
+- the docstring for letf mutters something about "deprecated usage of\r
+  `symbol-function' in place forms.\r
+\r
+On the third hand, \r
+\r
+   http://www.gnu.org/software/emacs/manual/html_node/elisp/Setting-Generalized-Variables.html#Setting-Generalized-Variables \r
+\r
+suggests using symbol-function with setf is legitimate.\r