Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures

diff --git a/94/b5026e538a79e8585c8c5d7be23e4d9b8dbfbb b/94/b5026e538a79e8585c8c5d7be23e4d9b8dbfbb
new file mode 100644 (file)
index 0000000..09c9fdb
--- /dev/null
+++ b/94/b5026e538a79e8585c8c5d7be23e4d9b8dbfbb
@@ -0,0 +1,73 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8DCD1431FD4\r
+       for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 16:53:53 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 1vPRKrpDxtOJ for <notmuch@notmuchmail.org>;\r
+       Sun, 17 Nov 2013 16:53:47 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3ED39431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 16:53:47 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1ViD5y-0004ct-RL; Sun, 17 Nov 2013 20:53:42 -0400\r
+Received: (nullmailer pid 16971 invoked by uid 1000); Mon, 18 Nov 2013\r
+       00:53:39 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 5/5] compact: provide user more information on\r
+       after-compaction failures\r
+In-Reply-To: <m2pppzm4ja.fsf@guru.guru-group.fi>\r
+References: <1384362167-12740-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1384362167-12740-6-git-send-email-tomi.ollila@iki.fi>\r
+       <871u2jnkai.fsf@nikula.org> <87y54rx8sf.fsf@unb.ca>\r
+       <m28uwquccd.fsf@guru.guru-group.fi> <8738mvz2fy.fsf@zancas.localnet>\r
+       <m2pppzm4ja.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16+167~g9838fe8 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 17 Nov 2013 20:53:38 -0400\r
+Message-ID: <87wqk6y1gt.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 18 Nov 2013 00:53:53 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+> I was thinking naming the function notmuch_database_compact_internal ()\r
+> as one option (I also though of notmuch_database_compact_unstable () -- but\r
+> that sounds so "unstable" (at least outside Debian people ;D)) --\r
+> could be one option. Then developers should understand the API is not\r
+> fixed there...\r
+\r
+I think 0.18 will just be an API breaking release in general; compact is\r
+probably the least of people's worries. Yes, it's a bit more irritating\r
+because the API will be short lived, but since we plan to change\r
+notmuch_database_open, pretty much every client of the library will have\r
+to update anyway. Luckily there probably aren't enough such clients to\r
+get a really good lynch mob together.  I'd suggest just mentioning it\r
+NEWS for 0.17 that the library interface for compact is expected to\r
+change in 0.18.\r
+\r
+d\r