Re: [PATCH v2 11/13] emacs: code cleanup in `notmuch-show-operate-all', no functional...

diff --git a/d8/60b0ee8c963127bd38511b3413bdc2cf619408 b/d8/60b0ee8c963127bd38511b3413bdc2cf619408
new file mode 100644 (file)
index 0000000..ac21447
--- /dev/null
+++ b/d8/60b0ee8c963127bd38511b3413bdc2cf619408
@@ -0,0 +1,120 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4A36A429E34\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:00:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Odp1eDQs8fTn for <notmuch@notmuchmail.org>;\r
+       Sun, 29 Jan 2012 20:59:59 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
+       [18.7.68.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6971F431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 20:59:59 -0800 (PST)\r
+X-AuditID: 12074424-b7fae6d000000906-98-4f2623ce36e9\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id A0.4D.02310.EC3262F4; Sun, 29 Jan 2012 23:59:58 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0U4xvOD013047; \r
+       Sun, 29 Jan 2012 23:59:58 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0U4xu2D000317\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sun, 29 Jan 2012 23:59:57 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1RrjKe-0000WW-9f; Sun, 29 Jan 2012 23:59:08 -0500\r
+Date: Sun, 29 Jan 2012 23:59:08 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH v2 11/13] emacs: code cleanup in\r
+       `notmuch-show-operate-all', no functional changes\r
+Message-ID: <20120130045908.GO17991@mit.edu>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327890382-548-12-git-send-email-dmitry.kurochkin@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1327890382-548-12-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hRV1j2nrOZv8GShucXVrf3sFtdvzmR2\r
+       YPLYOesuu8ezVbeYA5iiuGxSUnMyy1KL9O0SuDIubJ3PUrCHr+LJvX3sDYwrubsYOTkkBEwk\r
+       fhw9yAhhi0lcuLeerYuRi0NIYB+jxJHO5+wQzgZGiW1Hp4JVCQmcZJJ48c4dIrGEUaJl21l2\r
+       kASLgKrEmodTWEFsNgENiW37l4M1iAgYSty6+IoZxGYWkJb49ruZCcQWFsiQePfiJFgvr4CO\r
+       xK95XSwQQ08wSrS/XcEMkRCUODnzCQtEs5bEjX8vgZo5wAYt/8cBEuYU8JJYNP062F5RARWJ\r
+       KSe3sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Zrr5WaW6KWmlG5i\r
+       BAU2u4vKDsbmQ0qHGAU4GJV4eAP/qfoLsSaWFVfmHmKU5GBSEuV1UVLzF+JLyk+pzEgszogv\r
+       Ks1JLT7EKMHBrCTC++gnUDlvSmJlVWpRPkxKmoNFSZxXQ+udn5BAemJJanZqakFqEUxWhoND\r
+       SYL3P8hQwaLU9NSKtMycEoQ0EwcnyHAeoOGcwEQgxFtckJhbnJkOkT/FqCglzvsBpFkAJJFR\r
+       mgfXC0s8rxjFgV4R5n0BUsUDTFpw3a+ABjMBDX7OAHJ1cUkiQkqqgXGS1/evHH93f1fZrXhC\r
+       vlYz7Ctfi7N+n+Av5y//Pt2x1/3d0bVcVeFqa/NpBmMRja2yri8Kg2aJMT3OZXb+ffPLrwN9\r
+       R6ZUbZn4bOmjg1fWRRtKTtqafaigzMJ4mXCvZeVMw1svQyfdX9rqXtCTujJJTDY33Ero4YRg\r
+       yUl9a2VV66MltD8K+iuxFGckGmoxFxUnAgBl00MDFwMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 05:00:01 -0000\r
+\r
+notmuch-show-tag-all, in the first line of the commit message.\r
+\r
+As in the previous patch, if the previous patch comes earlier in the\r
+series, notmuch-show-tag-all could be written this way initially.\r
+\r
+Quoth Dmitry Kurochkin on Jan 30 at  6:26 am:\r
+> Use `notmuch-show-mapc' function instead of a custom `loop'.\r
+> ---\r
+>  emacs/notmuch-show.el |   13 ++++++-------\r
+>  1 files changed, 6 insertions(+), 7 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index b115a8f..69381ac 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1516,13 +1516,12 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+>  TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+>    (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))\r
+>    (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)\r
+> -  (save-excursion\r
+> -    (goto-char (point-min))\r
+> -    (loop do (let* ((current-tags (notmuch-show-get-tags))\r
+> -                (new-tags (notmuch-update-tags current-tags tag-changes)))\r
+> -           (unless (equal current-tags new-tags)\r
+> -             (notmuch-show-set-tags new-tags)))\r
+> -      while (notmuch-show-goto-message-next))))\r
+> +  (notmuch-show-mapc\r
+> +   (lambda ()\r
+> +     (let* ((current-tags (notmuch-show-get-tags))\r
+> +        (new-tags (notmuch-update-tags current-tags tag-changes)))\r
+> +       (unless (equal current-tags new-tags)\r
+> +     (notmuch-show-set-tags new-tags))))))\r
+>  \r
+>  (defun notmuch-show-add-tag ()\r
+>    "Same as `notmuch-show-tag' but sets initial input to '+'."\r
+\r
+-- \r
+Austin Clements                                      MIT/'06/PhD/CSAIL\r
+amdragon@mit.edu                           http://web.mit.edu/amdragon\r
+       Somewhere in the dream we call reality you will find me,\r
+              searching for the reality we call dreams.\r