Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

diff --git a/5e/c3c60291a8a0caeab0cc0c5c4c4d3b912f6f9d b/5e/c3c60291a8a0caeab0cc0c5c4c4d3b912f6f9d
new file mode 100644 (file)
index 0000000..d957ca2
--- /dev/null
+++ b/5e/c3c60291a8a0caeab0cc0c5c4c4d3b912f6f9d
@@ -0,0 +1,94 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 48307431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 26 Dec 2012 19:24:02 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id hQUe00uJARxk for <notmuch@notmuchmail.org>;\r
+       Wed, 26 Dec 2012 19:24:01 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7816B431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 26 Dec 2012 19:24:01 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1To44a-0003F7-Ge; Wed, 26 Dec 2012 23:23:56 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1To44U-0006cb-Qc; Wed, 26 Dec 2012 23:23:50 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Michael Forney <mforney@mforney.org>, Adrien Bustany <adrien@bustany.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t\r
+In-Reply-To: <1355276420-ner-1510@novus>\r
+References: <1342723401-26103-1-git-send-email-adrien@bustany.org>\r
+       <1350510742-13447-1-git-send-email-adrien@bustany.org>\r
+       <1355276420-ner-1510@novus>\r
+User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 26 Dec 2012 23:23:50 -0400\r
+Message-ID: <878v8kqit5.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 27 Dec 2012 03:24:02 -0000\r
+\r
+Michael Forney <mforney@mforney.org> writes:\r
+\r
+> On Thu, 18 Oct 2012 00:52:20 +0300, Adrien Bustany <adrien@bustany.org> wrote:\r
+>> The code of the patches in unchanged, but the formatting issues are now\r
+>> hopefully fixed.\r
+>\r
+> I would like to bump this patch set. I also need these features from\r
+> libnotmuch. Currently there is no way to recover from Xapian errors,\r
+> which is pretty limiting.\r
+>\r
+> If it is the flush/commit that is the issue, I would be happy to make an\r
+> updated patch set.\r
+\r
+Hi Michael;\r
+\r
+Right, we should use the current name of 'commit'. We also need some way\r
+to check the xapian version in the configure script, and to make sure\r
+the right name is supported.\r
+\r
+Jani refers to \r
+\r
+     id:1350487737-32058-2-git-send-email-bgamari.foss@gmail.com\r
+\r
+farther up the thread as having some relevant code/ideas.\r
+\r
+I think it's reasonable to require Xapian version at least 1.2.0, so\r
+that might simplify the configuration check. \r
+\r
+The other thing I wondered is if the error handling in these routines is\r
+as good as it could be. I guess it isn't worse than what is there, but\r
+especially since you are explicitly wanting to handle error conditions,\r
+it would be good to think if we can do something better than adding yet\r
+another printf to the library.\r
+\r
+d\r