Re: [PATCH 4/4] emacs: Use the new JSON reply format.

diff --git a/83/228b3b4a9a252453cf2624213d1afda4d35f98 b/83/228b3b4a9a252453cf2624213d1afda4d35f98
new file mode 100644 (file)
index 0000000..07314e5
--- /dev/null
+++ b/83/228b3b4a9a252453cf2624213d1afda4d35f98
@@ -0,0 +1,98 @@
+Return-Path: <awg@xvx.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3D9E6431FD0\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Jan 2012 18:10:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id eiXeBZR5sOiT for <notmuch@notmuchmail.org>;\r
+       Mon,  9 Jan 2012 18:10:50 -0800 (PST)\r
+Received: from mail-ey0-f181.google.com (mail-ey0-f181.google.com\r
+       [209.85.215.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 5965D431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Jan 2012 18:10:50 -0800 (PST)\r
+Received: by eaai1 with SMTP id i1so3019612eaa.26\r
+       for <notmuch@notmuchmail.org>; Mon, 09 Jan 2012 18:10:49 -0800 (PST)\r
+MIME-Version: 1.0\r
+Received: by 10.204.156.219 with SMTP id y27mr7919338bkw.71.1326161448804;\r
+       Mon, 09 Jan 2012 18:10:48 -0800 (PST)\r
+Received: by 10.205.33.73 with HTTP; Mon, 9 Jan 2012 18:10:48 -0800 (PST)\r
+X-Originating-IP: [12.50.241.130]\r
+In-Reply-To: <cun62gl1cqv.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <1326009162-19524-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <1326009162-19524-5-git-send-email-awg+notmuch@xvx.ca>\r
+       <cun62gl1cqv.fsf@hotblack-desiato.hh.sledj.net>\r
+Date: Mon, 9 Jan 2012 19:10:48 -0700\r
+Message-ID:\r
+ <CAMoJFUt8F417wzSmiHDv2KHa9y5ARYh=xRHKEsWBXYXHfaN64A@mail.gmail.com>\r
+Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format.\r
+From: Adam Wolfe Gordon <awg@xvx.ca>\r
+To: David Edmondson <dme@dme.org>\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+Content-Transfer-Encoding: quoted-printable\r
+X-Mailman-Approved-At: Wed, 11 Jan 2012 18:03:20 -0800\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 10 Jan 2012 02:10:51 -0000\r
+\r
+Hi David,\r
+\r
+Thanks for the review.  Most of the things you've suggested are easy\r
+changes, and I think obvious improvements, so I'll change them for the\r
+next version.  A bit of discussion on the more involved things below:\r
+\r
+On Mon, Jan 9, 2012 at 01:50, David Edmondson <dme@dme.org> wrote:\r
+> On Sun, =A08 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon <awg+notmuch@xvx.=\r
+ca> wrote:\r
+>> +(defun w3m-region (start end)) ;; From `w3m.el'.\r
+>> +(defun notmuch-mua-quote-part (part)\r
+>> + =A0(with-temp-buffer\r
+>> + =A0 =A0(insert part)\r
+>> + =A0 =A0(message-mode)\r
+>> + =A0 =A0(fill-region (point-min) (point-max))\r
+>> + =A0 =A0(goto-char (point-min))\r
+>> + =A0 =A0(perform-replace "^" "> " nil t nil)\r
+>> + =A0 =A0(set-buffer-modified-p nil)\r
+>> + =A0 =A0(buffer-substring (point-min) (point-max))))\r
+>\r
+> Couldn't all of this be done directly in the reply buffer?\r
+\r
+Indeed, it could, I just hadn't thought of it.  I'll do this for the\r
+next version.\r
+\r
+> Using w3m means that you should `require' it. What happens when a user\r
+> doesn't have it? (Either the elisp or the command.)\r
+\r
+This was my initial thought, but when I looked at notmuch-show.el,\r
+which uses w3m features, I noticed that it doesn't have a require.  To\r
+be clear, this patch requires w3m.el (not just the w3m binary), which\r
+I don't think anything else in notmuch does.\r
+\r
+In the previous version I had a customize variable specifying whether\r
+to quote HTML parts, which meant that if the user could set the\r
+customize variable to false and everything would work without w3m.el.\r
+I'd like not to introduce a new prerequisite, so if there's a way to\r
+make w3m.el optional that would be my preference.  Can you provide\r
+some guidance on this?\r
+\r
+--=20\r
+Adam Wolfe Gordon\r