--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id D3580431FAF\r
+ for <notmuch@notmuchmail.org>; Sun, 5 May 2013 03:48:36 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 82qVG9aZXIVg for <notmuch@notmuchmail.org>;\r
+ Sun, 5 May 2013 03:48:32 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id 73751431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 5 May 2013 03:48:32 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 58AC7100033;\r
+ Sun, 5 May 2013 13:48:31 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, Jani Nikula <jani@nikula.org>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH REBASE] emacs: add show view bindings to move to\r
+ previous/next thread\r
+In-Reply-To: <87bo8q72u3.fsf@qmul.ac.uk>\r
+References: <1367514302-30196-1-git-send-email-jani@nikula.org>\r
+ <87bo8q72u3.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 05 May 2013 13:48:31 +0300\r
+Message-ID: <m21u9lya68.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 May 2013 10:48:37 -0000\r
+\r
+On Sun, May 05 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> Hi\r
+>\r
+> This seems like a useful addition to me. I have a couple of comments and\r
+> a little bikeshedding below.\r
+>\r
+> On Thu, 02 May 2013, Jani Nikula <jani@nikula.org> wrote:\r
+>> We have most of the plumbing in place, add the bindings M-n and M-p.\r
+>> ---\r
+>> emacs/notmuch-show.el | 24 ++++++++++++++++++++++++\r
+>> 1 file changed, 24 insertions(+)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index face2a0..7f6ea65 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -39,6 +39,7 @@\r
+>> \r
+>> (declare-function notmuch-call-notmuch-process "notmuch" (&rest args))\r
+>> (declare-function notmuch-search-next-thread "notmuch" nil)\r
+>> +(declare-function notmuch-search-previous-thread "notmuch" nil)\r
+>> (declare-function notmuch-search-show-thread "notmuch" nil)\r
+>> \r
+>> (defcustom notmuch-message-headers '("Subject" "To" "Cc" "Date")\r
+>> @@ -1267,6 +1268,8 @@ reset based on the original query."\r
+>> (define-key map "P" 'notmuch-show-previous-message)\r
+>> (define-key map "n" 'notmuch-show-next-open-message)\r
+>> (define-key map "p" 'notmuch-show-previous-open-message)\r
+>> + (define-key map (kbd "M-n") 'notmuch-show-next-thread-show)\r
+>> + (define-key map (kbd "M-p") 'notmuch-show-previous-thread-show)\r
+>\r
+> These seem sensible bindings.\r
+>\r
+>> (define-key map (kbd "DEL") 'notmuch-show-rewind)\r
+>> (define-key map " " 'notmuch-show-advance-and-archive)\r
+>> (define-key map (kbd "M-RET") 'notmuch-show-open-or-close-all)\r
+>> @@ -1839,6 +1842,27 @@ argument, hide all of the messages."\r
+>> (if show-next\r
+>> (notmuch-search-show-thread)))))\r
+>> \r
+>> +(defun notmuch-show-previous-thread (&optional show-previous)\r
+>> + "Move to the next item in the search results, if any."\r
+> ^^\r
+> Should be previous item.\r
+>\r
+>> + (interactive "P")\r
+>> + (let ((parent-buffer notmuch-show-parent-buffer))\r
+>> + (notmuch-kill-this-buffer)\r
+>> + (when (buffer-live-p parent-buffer)\r
+>> + (switch-to-buffer parent-buffer)\r
+>> + (notmuch-search-previous-thread)\r
+>> + (if show-previous\r
+>> + (notmuch-search-show-thread)))))\r
+>> +\r
+>\r
+> If you change this to \r
+> (if (and (notmuch-search-previous-thread) show-previous)\r
+> (notmuch-search-show-thread)))))\r
+> then if you apply it to the first thread it jumps back to the search menu which is\r
+> consistent with the next-thread version.\r
+\r
+notmuch-search-next-thread & notmuch-search-previous-thread behaves\r
+differently when it comes to the end... previous always points\r
+to thread but next goes to the end. This is OK for interactive point\r
+of view but for noninteractive use one needs to do special handling...\r
+\r
+> I would have a slight preference for adding another optional argument \r
+> notmuch-show-next-thread (&optional show-message previous)\r
+>\r
+> where if PREVIOUS is set then it would go back otherwise forward. But I\r
+> with the duplicated version too.\r
+\r
+... what we need is lower level (noninteractive) function (taking PREVIOUS\r
+as an arg) which signals when it cannot get next/previous function...\r
+and then this notmuch-show-next-thread (&optional show-message previous)\r
+just calls it (with proper handling block) in place of\r
+notmuch-search-next-thread (maybe notmuch-search-previous-or-next-thread).\r
+\r
+This would be a bit cleaner.\r
+\r
+If this is not done, then I'd just go with Mark's suggestion of checking\r
+the return value of notmuch-search-previous-thread, and if you (jani)\r
+wish combine this functionality to notmuch-show-next-thread.\r
+\r
+\r
+> Best wishes\r
+>\r
+> Mark\r
+\r
+Tomi\r
+\r
+>\r
+>\r
+>> +(defun notmuch-show-next-thread-show ()\r
+>> + "Show the next thread in the search results, if any."\r
+>> + (interactive)\r
+>> + (notmuch-show-next-thread t))\r
+>> +\r
+>> +(defun notmuch-show-previous-thread-show ()\r
+>> + "Show the previous thread in the search results, if any."\r
+>> + (interactive)\r
+>> + (notmuch-show-previous-thread t))\r
+>> +\r
+>> (defun notmuch-show-archive-thread (&optional unarchive)\r
+>> "Archive each message in thread.\r
+>> \r
+>> -- \r
+>> 1.7.10.4\r
projects / notmuch-archives.git / commitdiff