Re: [PATCH v3 part 3/3] test: implement and document NOTMUCH_TEST_QUIET variable...

diff --git a/c6/7e034889ad2edee7350d2f06727da9e5f51daa b/c6/7e034889ad2edee7350d2f06727da9e5f51daa
new file mode 100644 (file)
index 0000000..a008ab2
--- /dev/null
+++ b/c6/7e034889ad2edee7350d2f06727da9e5f51daa
@@ -0,0 +1,111 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C5BD7431FD0\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Dec 2013 16:33:27 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 43WkgASZWzUB for <notmuch@notmuchmail.org>;\r
+       Sun,  8 Dec 2013 16:33:20 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu\r
+       [18.7.68.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 33B52431FCB\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Dec 2013 16:33:20 -0800 (PST)\r
+X-AuditID: 12074422-b7f9d6d000000bc0-ad-52a50fcf1ab9\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       (using TLS with cipher AES256-SHA (256/256 bits))\r
+       (Client did not present a certificate)\r
+       by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 27.6A.03008.FCF05A25; Sun,  8 Dec 2013 19:33:19 -0500 (EST)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id rB90XIfW018130; \r
+       Sun, 8 Dec 2013 19:33:19 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id rB90XG80008050\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Sun, 8 Dec 2013 19:33:17 -0500\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1Vpomh-0006QM-SI; Sun, 08 Dec 2013 19:33:15 -0500\r
+Date: Sun, 8 Dec 2013 19:33:15 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH v3 part 3/3] test: implement and document\r
+       NOTMUCH_TEST_QUIET variable usage\r
+Message-ID: <20131209003315.GA24583@mit.edu>\r
+References: <1385399299-12936-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1386247560-31903-1-git-send-email-tomi.ollila@iki.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1386247560-31903-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hTV1j3PvzTI4Gi7lsX1mzOZLd6snMfq\r
+       wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGUc3jeRpeA1e8W/bYsZGxhb2LoYOTkkBEwk\r
+       Nmxbzgxhi0lcuLceKM7FISQwm0li9sw5LBDOBkaJXbOeMkE4p5gkmiZfZYRwljBKrHqzgh2k\r
+       n0VARWL67AWsIDabgIbEtv3LGUFsEaD4g7b1YHFmAWmJb7+bmUBsYYFEiTlXz4Lt5hXQkejs\r
+       2Qs2R0igWuJMzz+ouKDEyZlPWCB6tSRu/HsJ1MsBNmf5Pw6QMKeAs8TBl1fBxosCrZpychvb\r
+       BEahWUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGuqV5uZoleakrpJkZQYLO7\r
+       KO1g/HlQ6RCjAAejEg/vCtalQUKsiWXFlbmHGCU5mJREeSdzA4X4kvJTKjMSizPii0pzUosP\r
+       MUpwMCuJ8CqdWBIkxJuSWFmVWpQPk5LmYFES573FYR8kJJCeWJKanZpakFoEk5Xh4FCS4H3H\r
+       BzRUsCg1PbUiLTOnBCHNxMEJMpwHaHgUSA1vcUFibnFmOkT+FKOilDgvJzB1CAmAJDJK8+B6\r
+       YYnnFaM40CvCvJdB2nmASQuu+xXQYCagwZOuLgIZXJKIkJJqYOSXneF45+c35zVac/ek3rKf\r
+       mJNfJaUh/LZX5OVM59iHe2tmT94W3H7x+3cDgbafnnksSsrdmWyd1Rm35Re9maDm/O3o2plr\r
+       mBc+WX9jr6Xct9qLWv5Rpy5yaKz9Knswr+nXkpfl4iIFxtldfZxH1SJf64gENBsu0b7YqX1h\r
+       e+MJi022/pMDHymxFGckGmoxFxUnAgBv37V+FwMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Dec 2013 00:33:28 -0000\r
+\r
+v3 LGTM.\r
+\r
+Quoth Tomi Ollila on Dec 05 at  2:46 pm:\r
+> When NOTMUCH_TEST_QUIET environment variable is set to non-null value\r
+> messages when new test script starts and when test PASSes are disabled.\r
+> This eases picking the cases when tests FAIL (as those are still printed).\r
+> ---\r
+> \r
+> Diffdiff of part 3 to previous.\r
+> \r
+> | diff --git a/test/test-lib.sh b/test/test-lib.sh\r
+> | index 9d4a807..d8e0d91 100644\r
+> | --- a/test/test-lib.sh\r
+> | +++ b/test/test-lib.sh\r
+> | @@ -733,9 +733,7 @@ test_failure_ () {\r
+> |            return\r
+> |    fi\r
+> |    test_failure=$(($test_failure + 1))\r
+> | -  if test -n "$NOTMUCH_TEST_QUIET"; then\r
+> | -          print_test_description\r
+> | -  fi\r
+> | +  print_test_description\r
+> |    test_failure_message_ "FAIL" "$test_subtest_name" "$@"\r
+> |    test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; }\r
+> |    return 1\r
+> \r
+> \r
+>  test/README      | 8 ++++++++\r
+>  test/basic       | 4 ++--\r
+>  test/test-lib.sh | 9 ++++++++-\r
+>  3 files changed, 18 insertions(+), 3 deletions(-)\r