Re: [PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

diff --git a/8f/61965c2a6d864a425d13fea755033a7b84ba83 b/8f/61965c2a6d864a425d13fea755033a7b84ba83
new file mode 100644 (file)
index 0000000..fe7506d
--- /dev/null
+++ b/8f/61965c2a6d864a425d13fea755033a7b84ba83
@@ -0,0 +1,88 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 07729421192\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Jun 2011 15:35:41 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8QC5vZFi5SKR for <notmuch@notmuchmail.org>;\r
+       Wed, 29 Jun 2011 15:35:40 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id 82F5042118E\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Jun 2011 15:35:40 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 8D62D29A852;\r
+       Wed, 29 Jun 2011 15:35:39 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 7D8362541A8; Wed, 29 Jun 2011 15:35:39 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] new: Don't update DB mtime if FS mtime equals\r
+       wall-clock time.\r
+In-Reply-To: <1309331455-19584-1-git-send-email-amdragon@mit.edu>\r
+References: <1309331455-19584-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Wed, 29 Jun 2011 15:35:33 -0700\r
+Message-ID: <87oc1g466i.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Cc: amdragon@mit.edu\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 Jun 2011 22:35:41 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Wed, 29 Jun 2011 03:10:54 -0400, Austin Clements <amdragon@MIT.EDU> wrot=\r
+e:\r
+> This fixes a race where multiple message deliveries in the same second\r
+> with an intervening notmuch new could result in messages being ignored\r
+> by notmuch (at least, until a later delivery forced a rescan).\r
+\r
+Excellent fix, Austin.\r
+\r
+I've merged this, (and the following commit to drop the ugly\r
+increment_mtime).\r
+\r
+I think that even fixes an outstanding portability bug (where someone\r
+previously sent patches to change our implementation of\r
+increment_mtime).\r
+\r
+It's sure nice to see notmuch become more robust all the time.\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk4LqLUACgkQ6JDdNq8qSWirSgCfaf6r59r8VTLRrNNPqXSNPcXO\r
+tn4AoKPlRf9yDCGV8h1fmLzLCnyurqcx\r
+=7hHA\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r