--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id F2FDB431FB6\r
+ for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 19:23:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id OpRSjuwr4tQ0 for <notmuch@notmuchmail.org>;\r
+ Tue, 27 Dec 2011 19:23:01 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
+ [18.9.25.14])\r
+ by olra.theworths.org (Postfix) with ESMTP id 31348431FD0\r
+ for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 19:23:01 -0800 (PST)\r
+X-AuditID: 1209190e-b7f7c6d0000008c3-6f-4efa8b94720b\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+ by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 90.14.02243.49B8AFE4; Tue, 27 Dec 2011 22:23:00 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id pBS3Mx8o030450\r
+ for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 22:23:00 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pBS3MwBO009119\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT)\r
+ for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 22:22:59 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>) id 1Rfk7H-0001Pd-PF\r
+ for notmuch@notmuchmail.org; Tue, 27 Dec 2011 22:23:47 -0500\r
+Date: Tue, 27 Dec 2011 22:23:47 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: notmuch <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME\r
+ traversal.\r
+Message-ID: <20111228032347.GA30150@mit.edu>\r
+References: <1323027100-10307-1-git-send-email-amdragon@mit.edu>\r
+ <1323460468-4030-1-git-send-email-amdragon@mit.edu>\r
+ <1323460468-4030-3-git-send-email-amdragon@mit.edu>\r
+ <87k46572f7.fsf@gmail.com> <20111224034500.GA1927@mit.edu>\r
+ <4EF9D5E8.4050203@fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <4EF9D5E8.4050203@fifthhorseman.net>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsUixCmqrDul+5efwacbYhbXb85kdmD0eLbq\r
+ FnMAYxSXTUpqTmZZapG+XQJXxv1LTawFB7gqek+1sTUwfmXvYuTkkBAwkZi8dw0bhC0mceHe\r
+ eiCbi0NIYB+jxKpHixghnHOMEif2vGKCcJ4zSax+f58ZwjkEVLZ7LQtIP4uAqsSNa09ZQWw2\r
+ AQ2JbfuXM4LYIkDxTWvvAtkcHMICERJPd9SBhHkFdCSmHX0MtW4Sk8Sht/dYIRKCEidnPgGb\r
+ ySygJXHj30smkF5mAWmJ5f84QMKcAoYSb75uZQKxRQVUJKac3MY2gVFwFpLuWUi6ZyF0L2Bk\r
+ XsUom5JbpZubmJlTnJqsW5ycmJeXWqRrrJebWaKXmlK6iREcrJJ8Oxi/HlQ6xCjAwajEw3vr\r
+ 7U8/IdbEsuLK3EOMkhxMSqK8Xl2//IT4kvJTKjMSizPii0pzUouB4cHBrCTCa/kAqJw3JbGy\r
+ KrUoHyYlzcGiJM6rpvXOT0ggPbEkNTs1tSC1CCYrw8GhJMGrDIxKIcGi1PTUirTMnBKENBMH\r
+ J8hwHqDhz0EW8xYXJOYWZ6ZD5E8xKkqJ8wqCNAuAJDJK8+B6YcnkFaM40CvCvAwgVTzARATX\r
+ /QpoMBPQ4DjlHyCDSxIRUlINjDnfRIN+8dxeNe3fmg9dld4CKX6n+sXDq77sqd7CE1A03aQ7\r
+ mV98Ltsxh2m/t/OkBH80zdm+dD+bgsLPC6Krpre9mHrlbee1+wwVL3b4SK13v+PRsG3hTmUV\r
+ y8DrlYemas+TKjfkXWu7gqViwpvpm05uNzlctPf4qcSLlpNZpSfd/Hk+8MqZahslluKMREMt\r
+ 5qLiRACcsZ0vAQMAAA==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 28 Dec 2011 03:23:02 -0000\r
+\r
+Quoth Daniel Kahn Gillmor on Dec 27 at 9:27 am:\r
+> On 12/23/2011 10:45 PM, Austin Clements wrote:\r
+> > Quoth Dmitry Kurochkin on Dec 10 at 3:25 am:\r
+> >> + /* For some reason the GMimeSignatureValidity returned\r
+> >> + * here is not a const (inconsistent with that\r
+> >> + * returned by\r
+> >> + * g_mime_multipart_encrypted_get_signature_validity,\r
+> >> + * and therefore needs to be properly disposed of.\r
+> >> + * Hopefully the API will become more consistent. */\r
+> >>\r
+> >> Ouch. In gmime 2.6 this API has changed, but looks like the\r
+> >> issue is still there. Is there a bug for it? If yes, we should\r
+> >> add a reference to the comment. Otherwise, we should file the\r
+> >> bug and then add a reference to the comment :)\r
+> > \r
+> > It looks like they're both non-const in 2.6 (which makes more sense to\r
+> > me). I updated the comment to mention this.\r
+> \r
+> Here's the bug report where this was discussed with upstream, fwiw:\r
+> \r
+> https://bugzilla.gnome.org/show_bug.cgi?id=640911\r
+\r
+Oh, are we not supposed to be disposing of the GMimeSignatureValidity\r
+returned by g_mime_multipart_encrypted_get_signature_validity\r
+ourselves? Comment 1 on that bug report suggests that we shouldn't.\r
+The old show code did, so I ported that behavior over to the new code.\r
projects / notmuch-archives.git / commitdiff