--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2D736431FAF\r
+ for <notmuch@notmuchmail.org>; Sat, 17 Mar 2012 08:50:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 27hqDDUAxzmx for <notmuch@notmuchmail.org>;\r
+ Sat, 17 Mar 2012 08:50:27 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
+ [18.9.25.15])\r
+ by olra.theworths.org (Postfix) with ESMTP id 5D68C431FAE\r
+ for <notmuch@notmuchmail.org>; Sat, 17 Mar 2012 08:50:27 -0700 (PDT)\r
+X-AuditID: 1209190f-b7f8a6d000000914-d4-4f64b2c17ae4\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+ by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 3E.EA.02324.1C2B46F4; Sat, 17 Mar 2012 11:50:25 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q2HFoPQj027685; \r
+ Sat, 17 Mar 2012 11:50:25 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2HFoNCF004098\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Sat, 17 Mar 2012 11:50:24 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1S8vtf-0003x5-5D; Sat, 17 Mar 2012 11:50:23 -0400\r
+Date: Sat, 17 Mar 2012 11:50:23 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 3/5] cli: move search to the new --exclude= naming scheme.\r
+Message-ID: <20120317155023.GH2670@mit.edu>\r
+References: <1331836925-31437-1-git-send-email-markwalters1009@gmail.com>\r
+ <1331836925-31437-4-git-send-email-markwalters1009@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1331836925-31437-4-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsUixG6nontwU4q/wcKdphar5/JYXL85k9mB\r
+ yWPnrLvsHs9W3WIOYIrisklJzcksSy3St0vgymj63sRccIu74vyCG+wNjBs5uxg5OSQETCSu\r
+ vXzCCmGLSVy4t56ti5GLQ0hgH6PEqqVnWCGcDYwSM08dZYRwTjJJbDnTCFW2hFFi0oTzTCD9\r
+ LAKqEgefXgObxSagIbFt/3JGEFtEQEfi9qEF7CA2s4C0xLffzWD1wgJ+Em8+zgar4RXQlljz\r
+ 9gkTxNBORom3M1+xQiQEJU7OfMIC0awlcePfS6AiDrBBy/9xgIQ5BbwkVv/dBjZfVEBFYsrJ\r
+ bWwTGIVmIemehaR7FkL3AkbmVYyyKblVurmJmTnFqcm6xcmJeXmpRbomermZJXqpKaWbGEGB\r
+ zSnJv4Px20GlQ4wCHIxKPLwcE5L9hVgTy4orcw8xSnIwKYnytm5I8RfiS8pPqcxILM6ILyrN\r
+ SS0+xCjBwawkwiu1HCjHm5JYWZValA+TkuZgURLnVdN65yckkJ5YkpqdmlqQWgSTleHgUJLg\r
+ /b4RqFGwKDU9tSItM6cEIc3EwQkynAdo+FeQGt7igsTc4sx0iPwpRl2O7qmPLjEKseTl56VK\r
+ ifMmAFOKkABIUUZpHtwcWEJ6xSgO9JYw7yWQUTzAZAY36RXQEiagJTPLkkGWlCQipKQaGCuF\r
+ Ti5Kb9/P/9F0q/C15coPV0S4Lyot1bPfl28YJXzRJ+nFjflfefoFnPZfm7w5Q99gQblmcHqB\r
+ 7/zNU7letb2tYtnSwxr65Mn6fOlVJbwbtGRnOwsb7/xk+PTMzUWntLPytrfliG5uN1xo80fq\r
+ fMbvOcFytaZ5DzawfDq7VY871l84uMdJXomlOCPRUIu5qDgRAOFWCAcjAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 17 Mar 2012 15:50:28 -0000\r
+\r
+Quoth Mark Walters on Mar 15 at 6:42 pm:\r
+> This commit replaces the --no-exclude option with a\r
+> --exclude=(true|false|flag) option. The default is to omit the\r
+> excluded messages.\r
+> \r
+> The flag option only makes sense if output=summary (as otherwise there\r
+> is nowhere to print the flag). In summary output exclude=false and\r
+> exclude=flag give almost identical output:\r
+> they differ in that with the exclude=flag option the match count\r
+> (i.e., the x in [x/n] in the output) is the number of matching\r
+> non-excluded messages rather than the number of matching messages.\r
+> \r
+> Note this changes the default for output=summary when no --exclude=\r
+> option is given: it used to default to flag and now defaults to true\r
+> (i.e. omit excluded messages). This is neccesary to keep the cli\r
+> output uncluttered and for speed reasons.\r
+> ---\r
+\r
+Code looks good, but I think there need to be a few more tests. In\r
+particular, I think we need all 10 valid combinations of\r
+\r
+* --output=summary or --output=messages (those two are probably\r
+ enough)\r
+\r
+* The three types of exclude (or two for --output=messages)\r
+\r
+* Whether or not an excluded term is in the query\r
+\r
+Finally, the corpus should have three threads of interest: a thread\r
+with no excluded messages, a thread with both excluded and\r
+non-excluded messages, and a thread consisting entirely of excluded\r
+messages.\r
+\r
+We already have many of these, but it would be good to systematically\r
+cover the full gamut of possibilities.\r
projects / notmuch-archives.git / commitdiff