Re: [PATCH v2] Output unmodified Content-Type header value for JSON format.

diff --git a/65/be4bf3c7fcc412d1e551d2d94cbe113ddff836 b/65/be4bf3c7fcc412d1e551d2d94cbe113ddff836
new file mode 100644 (file)
index 0000000..390b416
--- /dev/null
+++ b/65/be4bf3c7fcc412d1e551d2d94cbe113ddff836
@@ -0,0 +1,114 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 92715429E26\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:09:55 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id uUDElE5mJulG for <notmuch@notmuchmail.org>;\r
+       Thu, 12 Jan 2012 09:09:55 -0800 (PST)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ C0E70431FB6   for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:09:54 -0800\r
+ (PST)\r
+Received: by wgbds11 with SMTP id ds11so1947514wgb.2\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:09:53 -0800 (PST)\r
+Received: by 10.181.13.208 with SMTP id fa16mr7786908wid.12.1326388193621;\r
+       Thu, 12 Jan 2012 09:09:53 -0800 (PST)\r
+Received: from localhost ([109.131.126.209])\r
+       by mx.google.com with ESMTPS id di5sm10055363wib.3.2012.01.12.09.09.52\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 12 Jan 2012 09:09:52 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,\r
+       David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] Output unmodified Content-Type header value for JSON\r
+       format.\r
+In-Reply-To: <87obw6prpd.fsf@gmail.com>\r
+References: <1321659905-24367-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1321676321-27745-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87sjlktgi6.fsf@zancas.localnet> <87obw6prpd.fsf@gmail.com>\r
+User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Thu, 12 Jan 2012 18:08:08 +0100\r
+Message-ID: <87fwfkluh3.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 12 Jan 2012 17:09:55 -0000\r
+\r
+On Sun, 20 Nov 2011 22:35:42 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> On Sat, 19 Nov 2011 08:59:29 -0400, David Bremner <david@tethera.net> wrote:\r
+> > On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > > Before the change, notmuch used g_mime_content_type_to_string(3)\r
+> > > function to output Content-Type header value.  Turns out it outputs\r
+> > > only "type/subtype" part and ignores all parameters.  Also, if there\r
+> > > is no Content-Type header, default "text/plain" value is used.\r
+> > \r
+> > Hi Dmitry;\r
+> > \r
+> > I haven't analyzed the substance of your patch yet, but I did have a\r
+> > couple thoughts while reading your mail.\r
+> > \r
+> > - It seems that every time we change the json format, we have a round of\r
+> >   suffering because people are unable to detect a mismatch between their\r
+> >   emacs code and the cli. Not that this is your problem necessarily, but\r
+> >   it would be nice if someone (TM), would come up with some version info\r
+> >   for the json output, and a patch to check it on the emacs side.\r
+> > \r
+> \r
+> IMO this is a good idea.\r
+> \r
+> > - The previous point is a bit of a counterargument to this, but in\r
+> >   general, I think I prefer patches that modify the core seperate from\r
+> >   those that do emacs (or python, or ...) stuff.\r
+> > \r
+> \r
+> I couls separate it.  I made is a single patch to avoid having a\r
+> revision with broken emacs UI (and tests).\r
+> \r
+\r
+I'd like to propose to always apply patch series on a *topic* branch\r
+which would then be merged back into 'master', thus avoiding this issue\r
+altogether whilst making it more obvious which patches belong together\r
+(eg. for easier cross-referencing with the ML).\r
+\r
+> Regards,\r
+>   Dmitry\r
+> \r
+> > - I understand you want to make your patches reviewable without applying\r
+> >   by including lots of context, but at a certain point it has actually\r
+> >   the opposite effect for me. I just don't read 900+ line emails ;). Of\r
+> >   course, I can still apply the patch and look at it, so it's really up\r
+> >   to you.\r
+> > \r
+> > d\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r