Re: [PATCH v2] util: Fix two corner-cases in boolean term quoting function
authorDavid Bremner <david@tethera.net>
Sat, 15 Mar 2014 18:24:48 +0000 (15:24 +2100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:00:47 +0000 (10:00 -0800)
92/f07baae5994dabcb9ac540d42b8ad998ae6822 [new file with mode: 0644]

diff --git a/92/f07baae5994dabcb9ac540d42b8ad998ae6822 b/92/f07baae5994dabcb9ac540d42b8ad998ae6822
new file mode 100644 (file)
index 0000000..89af612
--- /dev/null
@@ -0,0 +1,62 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 810E2429E44\r
+       for <notmuch@notmuchmail.org>; Sat, 15 Mar 2014 11:25:02 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id mdhtmVtW2WGt for <notmuch@notmuchmail.org>;\r
+       Sat, 15 Mar 2014 11:24:57 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id CC1F8429E26\r
+       for <notmuch@notmuchmail.org>; Sat, 15 Mar 2014 11:24:57 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1WOtGO-0003y1-JS; Sat, 15 Mar 2014 15:24:52 -0300\r
+Received: (nullmailer pid 15441 invoked by uid 1000); Sat, 15 Mar 2014\r
+       18:24:48 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] util: Fix two corner-cases in boolean term quoting\r
+       function\r
+In-Reply-To: <1394570520-23279-1-git-send-email-amdragon@mit.edu>\r
+References: <1394570520-23279-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.17+133~g5348d19 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 15 Mar 2014 15:24:48 -0300\r
+Message-ID: <874n2zqpzj.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 15 Mar 2014 18:25:02 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> Previously, make_boolean_term did not quote empty boolean terms or\r
+> boolean terms that started with '('.  These cases are incompatible\r
+> with Xapian: empty terms cannot be omitted, and boolean terms that\r
+> start with '(' trigger an alternate term quoting syntax.\r
+\r
+pushed,\r
+\r
+d\r