Re: [PATCH v2 00/11] compactor changes v2

diff --git a/4d/0e1d5bc69f8fbe604f80844b599db9e904f2b4 b/4d/0e1d5bc69f8fbe604f80844b599db9e904f2b4
new file mode 100644 (file)
index 0000000..201b7b3
--- /dev/null
+++ b/4d/0e1d5bc69f8fbe604f80844b599db9e904f2b4
@@ -0,0 +1,85 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0A17B429E56\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 10:51:09 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Hq2MmpltExNs for <notmuch@notmuchmail.org>;\r
+       Tue,  5 Nov 2013 10:51:03 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id D80AC431FDD\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 10:51:02 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 753BD100051;\r
+       Tue,  5 Nov 2013 20:50:55 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 00/11] compactor changes v2\r
+In-Reply-To: <87k3gnqfb4.fsf@zancas.localnet>\r
+References: <cover.1383481295.git.jani@nikula.org>\r
+       <87k3gnqfb4.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.16+119~g219c55f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 05 Nov 2013 20:50:55 +0200\r
+Message-ID: <m21u2ubs34.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 05 Nov 2013 18:51:09 -0000\r
+\r
+On Tue, Nov 05 2013, David Bremner <david@tethera.net> wrote:\r
+\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>> Hi all, this is v2 of [1], incorporating compact related patches from\r
+>> David, some changes from David's review, some new patches, man page\r
+>> update, test update.\r
+>>\r
+>> Cheers,\r
+>> Jani.\r
+>\r
+> Aside from the one quibble that I already sent seperately, the first 8\r
+> patches look OK to me. I have no technical objections to the last 3, but\r
+> since the change the UI, I'd like to wait a bit for more input from\r
+> other people.\r
+\r
+\r
+The whole series looks OK to me. The only thing I'm, a bit worried about\r
+what happens is I Ctrl-C compaction at any state. Is it possible that I\r
+end up with corrupted database ? Someone may accidentally execute\r
+notmuch compact -- for example by picking the command from history.\r
+\r
+If it is possible what is the likelihood that happening (also comparing\r
+w/ notmuch tag, notmuch new & notmuch insert managing to corrupt database)\r
+\r
+I personally would like to be sure. OTOH if others don't see issue\r
+there (perhaps with a good reason) I'm fine with the patches as those\r
+are now.\r
+\r
+\r
+Tomi\r
+\r
+\r