don't rely on $@

A malformed pagespec will cause $@ to be set when translated, but if
it is used a second time, the memoization will defeat that check. Better to
check for the result not being defined.

diff --git a/IkiWiki.pm b/IkiWiki.pm
index d93ff7374069684a97e35c5626ec853e02d4ce47..2a3a84d9ae3586c529ae8e347f6c26107b15a413 100644 (file)
--- a/IkiWiki.pm
+++ b/IkiWiki.pm
@@ -1797,7 +1797,8 @@ sub pagespec_match ($$;@) {
        }
 
        my $sub=pagespec_translate($spec);
-       return IkiWiki::FailReason->new("syntax error in pagespec \"$spec\"") if $@;
+       return IkiWiki::FailReason->new("syntax error in pagespec \"$spec\"")
+               if $@ || ! defined $sub;
        return $sub->($page, @params);
 }