Re: [PATCH v2 00/11] compactor changes v2

diff --git a/5f/b9bd79641c16455b4f4b127932fcdc68ff098e b/5f/b9bd79641c16455b4f4b127932fcdc68ff098e
new file mode 100644 (file)
index 0000000..7215afd
--- /dev/null
+++ b/5f/b9bd79641c16455b4f4b127932fcdc68ff098e
@@ -0,0 +1,132 @@
+Return-Path: <bgamari.foss@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5CD32431E82\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 11:26:42 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8h5XgtpRI0JT for <notmuch@notmuchmail.org>;\r
+       Tue,  5 Nov 2013 11:26:35 -0800 (PST)\r
+Received: from mail-qc0-f172.google.com (mail-qc0-f172.google.com\r
+       [209.85.216.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 03FED431FDD\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 11:26:34 -0800 (PST)\r
+Received: by mail-qc0-f172.google.com with SMTP id c9so5094674qcz.17\r
+       for <notmuch@notmuchmail.org>; Tue, 05 Nov 2013 11:26:33 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=GJfJUTfT35FYyXnvcJU1U7DKhy3AAKsg4DKJrF9z2JA=;\r
+       b=Yx2nHtYFx6GCRUgDHx+mjWzzqvPMstEyYKzaiRUAonbTYnlyTzxF7pq7lt6kh6Wrr5\r
+       YrE/NIMC3BI1ZWOt58LHm7bzMyl0VNGcNiEIShX6y6NrJGzvZvOCgiZmIRAftVDemjtS\r
+       TKT779VWRRN7CvxrYvFNPlwXUL1t6qJvIt454rdP0ZFqWHbwcXZ/KukfDjr4XRoLix+g\r
+       su0ak+JoFaUoPXrnD4+7r9KiJpnNOpEFaamPedBL9a9G5JBSYbt9dq8xhYvxp7KoqKpl\r
+       1DtXmLHx8rdtu+0Tx+NpPVN8dI0Qneh2iwuqaJcikLgFeP2i6sbP2wVByNT46JNUahdV\r
+       jkeQ==\r
+X-Received: by 10.224.32.66 with SMTP id b2mr32196682qad.80.1383679593416;\r
+       Tue, 05 Nov 2013 11:26:33 -0800 (PST)\r
+Received: from localhost (physicsnat56.physics.umass.edu. [128.119.50.38])\r
+       by mx.google.com with ESMTPSA id u3sm61638010qej.8.2013.11.05.11.26.32\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Tue, 05 Nov 2013 11:26:32 -0800 (PST)\r
+From: Ben Gamari <bgamari.foss@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, David Bremner <david@tethera.net>,\r
+       Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 00/11] compactor changes v2\r
+In-Reply-To: <m21u2ubs34.fsf@guru.guru-group.fi>\r
+References: <cover.1383481295.git.jani@nikula.org>\r
+       <87k3gnqfb4.fsf@zancas.localnet>\r
+       <m21u2ubs34.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16+107~g1ef2773 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 05 Nov 2013 14:26:29 -0500\r
+Message-ID: <87wqkmhcpm.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 05 Nov 2013 19:26:42 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> On Tue, Nov 05 2013, David Bremner <david@tethera.net> wrote:\r
+>\r
+>> Jani Nikula <jani@nikula.org> writes:\r
+>>\r
+>>> Hi all, this is v2 of [1], incorporating compact related patches from\r
+>>> David, some changes from David's review, some new patches, man page\r
+>>> update, test update.\r
+>>>\r
+>>> Cheers,\r
+>>> Jani.\r
+>>\r
+>> Aside from the one quibble that I already sent seperately, the first 8\r
+>> patches look OK to me. I have no technical objections to the last 3, but\r
+>> since the change the UI, I'd like to wait a bit for more input from\r
+>> other people.\r
+>\r
+>\r
+> The whole series looks OK to me. The only thing I'm, a bit worried about\r
+> what happens is I Ctrl-C compaction at any state. Is it possible that I\r
+> end up with corrupted database ? Someone may accidentally execute\r
+> notmuch compact -- for example by picking the command from history.\r
+>\r
+You should in principle never end up in a situation where the original\r
+database is corrupted. Xapian's Compactor interface reads from the\r
+existing database and writes out the compacted database to a new\r
+directory. The notmuch compact command keeps the original database in\r
+place until the last possible moment.\r
+\r
+When the compacted database is completely constructed it, deletes or\r
+moves the old database out of the way and then moves the new database\r
+into place. The worst thing that could happen is that you manage to\r
+interrupt the process between deleting the old database and moving the\r
+new one into place (a very small window). In this case you'd simply need\r
+to move the new database into place manually (although you'd need to\r
+figure out where the compacted database is located).\r
+=20=20\r
+Cheers,\r
+\r
+=2D Ben\r
+\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.14 (GNU/Linux)\r
+\r
+iQEcBAEBAgAGBQJSeUZlAAoJEErkyLZmeNiDgewH/07rMTKEyc8J5AYoyRQK8HcU\r
+94ehZNt+xwKl/N6knhX5UE+KioJdXthCIDdTAiumLafZIwn6bQ6VtQgv+YrCBgVO\r
+C5Ay8UVTnK8gd6A7tqIAHPJPo8NC8WakccgbuPrTPDak1pPFgkiTfzg8LTmtKl7c\r
+tUBAcbpS3cBAPdAs/J948xtHpDQqr++tSxgH3cc0WGzlmBJbYszS9rwYWyCo5dX6\r
+dflXlcBbIDpcl4kn5+yHClc5024c6Riacu9XapXutCrs9j1hARKu+AEycupn4fLr\r
+qm+WcZ3OQbxI4Bhaomkizmpdj0nlinpfERF0Q/+qkV2l0RJKs+IEJ5xjlDqfSyA=\r
+=MnQw\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r