--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id C4998431FAF\r
+ for <notmuch@notmuchmail.org>; Sat, 6 Jul 2013 01:34:03 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id h2O7-K-e24Xt for <notmuch@notmuchmail.org>;\r
+ Sat, 6 Jul 2013 01:33:59 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id 4B587431FAE\r
+ for <notmuch@notmuchmail.org>; Sat, 6 Jul 2013 01:33:59 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 2C4DE100051;\r
+ Sat, 6 Jul 2013 11:33:53 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] contrib: pick: keybindings\r
+In-Reply-To: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+193~g7350bd4 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 06 Jul 2013 11:33:52 +0300\r
+Message-ID: <m2ppuwt7db.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 06 Jul 2013 08:34:03 -0000\r
+\r
+On Fri, Jul 05 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> This series adds lots of keybindings and funtionality to pick: in\r
+> particular it adds the stash keymap, the ability to tab between and\r
+> activate buttons in the message pane, and it reduces a lot of code\r
+> duplication between pick and show.\r
+>\r
+> It is a large series: but most of it is a lot of small changes. These\r
+> small changes are mostly logically independent but as they add\r
+> keybindings their contexts all clash. I have made most of the\r
+> keybindings as single separate patches to make discussion of them\r
+> individually easier.\r
+>\r
+> The key patches for review/discussion (apart from bike-shedding on\r
+> key-bindings!) are patches 1, 5 and 8.\r
+\r
+Now that you "asked", I'd ask what was used as a reason to decide "/"\r
+as keybinding for notmuch-pick-button-activate -- something common\r
+or as a convenience. In US/UK keyboard "/" is left to Right Shift,\r
+but for example in my keyboard it is Shift-7...\r
+\r
+> Patch 1 is the most "controversial": it over-rides\r
+> notmuch-show-get-prop so that whether it uses\r
+> notmuch-show-get-message-properties or\r
+> notmuch-pick-get-message-properties depends on the major-mode (ie\r
+> whether it is called from pick or show).\r
+\r
+At the moment the code comments could have something like XXX to\r
+emphasize the situation. IMHO it is ok to have this in contrib\r
+code -- when this is going to be "official" part of emacs MUA\r
+then this code needs to be ... well, at least moved to other place :D\r
+\r
+Apart from these code LGTM.\r
+\r
+Tomi\r
+\r
+\r
+> This means that functions from show which just use message properties\r
+> (most often just the message id) "just work" when called from pick. In\r
+> particular it gives us access to lots of functions without having to\r
+> duplicate the code.\r
+>\r
+> In the longer term it would be better to have some show/pick common\r
+> file and migrate the common functions there.\r
+>\r
+> Patch 5 and 8 add in functions for creating fucntions ready to be used\r
+> in keybindings. The one in patch 5 takes a show fucntion and creates a\r
+> function which switches from pick to the message pane, applies the\r
+> function and then switches back to pick. The one in patch 8 takes a\r
+> function and creates a function which closes the message pane and the\r
+> calls this function.\r
+>\r
+> Both of these make the keybinding section clearer. They also have the\r
+> advantage that the user can use them easily to create their own\r
+> keybindings which do this.\r
+>\r
+> This completes all the keybindings I use and I think means that pick\r
+> doesn't have any glaring omissions.\r
+>\r
+> Finally, this will clash with the thread archive patches\r
+> id:1371195472-441-1-git-send-email-markwalters1009@gmail.com\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+> Mark Walters (11):\r
+> contrib: pick: override notmuch-show-get-prop\r
+> contrib: pick: Link in notmuch-show-pipe-message\r
+> contrib: pick: Link in attachment functions straight from\r
+> notmuch-show\r
+> contrib: pick: Link in stash map straight from notmuch-show\r
+> contrib: pick: add in to-message-window function\r
+> contrib: pick: add button press helper\r
+> contrib: pick: pass tab through to the message pane\r
+> contrib: pick: close window function\r
+> contrib: pick: make help close the message pane first\r
+> contrib: pick: add in binding to view raw message\r
+> contrib: pick: use close-message-pane for reply etc\r
+>\r
+> contrib/notmuch-pick/notmuch-pick.el | 139 +++++++++++++++++-----------------\r
+> 1 files changed, 70 insertions(+), 69 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff